Repository navigation
Mesh_3 - reintroduce CGAL_MESH_3_USE_OLD_SURFACE_RESTRICTED_DELAUNAY_UPDATE - #9677
Draft
janetournois wants to merge 3 commits into
Draft
janetournois wants to merge 3 commits into
janetournois wants to merge 3 commits into
Conversation
to avoid the following case: * compute 3D Steiner point `p` * compute its conflict zone, fully internal in subdomain `s` * insert `p` * star the conflict region hole of `p` around it * relabel cells with subdomain `s` without checking if the restricted Delaunay is still valid. It is possible to have a newly created cell with its circumcenter outside the domain to be meshed This macro is not too expensive in labeled image domains, it is expensive for polyhedral domains
- find a seed that makes it fail without the macro - remove exuder that makes it fail anyhow!
Member
|
@MaelRL @janetournois What should we do with this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
to avoid the following case:
pspparound itswithout checking if the restricted Delaunay is still valid.It is possible to have a newly created cell with its circumcenter outside the domain to be meshed
Defining this macro is not too expensive in labeled image domains, it is expensive for polyhedral domains
Release Management
Todo