Repository navigation
Conversation
Although we will ignore that point in the builder of the offset polyhedron, some visitor such as the one used in skeleton extrusion expects to have an offset point for all skeleton halfedges that are intersected by the offset isoline.
The correct values are to be recomputed from the converted contours
And default it to SK, because conversion to exact kernel is very costly...
The core idea is to always produce a mesh. The mesh may be self-intersecting due to inexact constructions, but we get a mesh. The former approach simply computed for each face (+bottom & top) the contributions, and let PMP do some heavy work stitching things together. Now, we do things combinatorially, so by construction things are stitchable since the skeleton is combinatorially valid. If the triangulation fail due to inexact constructions, we use two fallbacks: - first one is to use a different projection traits - second one is to rebuild the face with a converted-to-exact skeleton and thus the boundary of the face is necessarily embedded (note that the sqrt error is absorbed at normalization; there can be no embedding issue with epeck) In the current state, the snapping was not adapted and is broken and disabled. It will be fixed in an upcoming commit.
With (0,0,0) as the origin, we can get some numerical issues for meshes with a very large bbox (1e9+)
MaelRL
force-pushed
the
SLS2-Extrusion_robustness-GF
branch
from
November 20, 2026 14:02
d195a20 to
1df4cad
Compare
Member
|
The CI failure is about dependencies: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
TODO:
Release Management
Straight_skeleton_extrusion_2