Repository navigation
[Surface_mesh] Add static assertion when Eigen is not available and default traits is used - #9864
Merged
sloriot merged 3 commits intoNov 20, 2026
Conversation
…s used Surface_mesh_deformation and Mean_curvature_flow_skeletonization rely on Eigen 3 as default traits. When compiled without Eigen3 and default traits are used, a static assertion with an explicit error message is now triggered instead of producing deep template error cascades. Assisted-by: Antigravity:gemini-2.5-pro
Member
|
Thanks for the PR, that's indeed a good idea. I think it's already implemented at some places but clearly not here. I'll check where else we could have the same patch. |
Contributor
Author
Thanks for reviewing! Let me know what you find. |
Member
|
Successfully tested in CGAL-6.3-Ic-137 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Surface_mesh_deformationandMean_curvature_flow_skeletonizationrely on Eigen 3 as their default linear solver / closest rotation traits. When compiled without Eigen 3 (CGAL_EIGEN3_ENABLEDnot defined) and the user relies on default traits, the compiler attempts to instantiate operations onCGAL::Default, producing hundreds of lines of cryptic template failure messages.This PR adds
static_assertstatements with clear, descriptive error messages instructing the user to either provide custom traits or link with the Eigen library, following the exact precedent established inFixed_border_parameterizer_3.handOrbifold_Tutte_parameterizer_3.h.Release Management
Surface_mesh_deformation,Surface_mesh_skeletonization