This repository was archived by the owner on Oct 7, 2026. It is now read-only.
Repository navigation
chore(ci): migrate PR review to the shared review harness (v2) - #6
Merged
Merged
Conversation
Replace the standalone claude-code-action review workflow with the thin caller stub for the shared agent-first-standards PR review harness, pinned to @v2. Renamed to code-review.yml; job key stays `review`. Dropped: @claude comment triggers, --allowedTools, the CLAUDE_REVIEW_MODEL model-selection step, --max-turns 10, draft/comment `if:` conditions, id-token: write, and the inline prompt/diff assembly steps. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The shared harness base prompt already owns review behavior (when to comment, no summary-only comments), so the repo prompt keeps domain conventions only. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
This repo is going to be archived soon, so I'll merge as it is, without fixing the CI. |
wojtha
approved these changes
Oct 6, 2026
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stakeholder Overview
Moves dm-core's PR review from a standalone
anthropics/claude-code-actionworkflow (claude-code-review.yml, which assembled the prompt and diff itself) to the shared CustomInk review harness (customink/agent-first-standards, pinned@v2). The workflow is now a thin caller stub,.github/workflows/code-review.yml, with job keyreview. The repo's own.claude/review-prompt.mdandCLAUDE.mdstay as the repo-specific review context.Risk Estimate
✅ Negligible risk!
CI configuration only; no library code changes. The only user-visible effect is how PR reviews are produced and posted.
gh api repos/customink/dm-core/branches/master/protection/required_status_checksreturns 404 "Required status checks not enabled", andgh api repos/customink/dm-core/rules/branches/masterreturns[](no rulesets). No required check matches the old job key (review) or workflow name (Claude Code Review), so nothing is orphaned.reviewjob key is kept; the check will render asreview / code.Click to expand!
.github/workflows/claude-code-review.ymlrenamed to.github/workflows/code-review.yml(git records it as delete + add, since the content is almost entirely replaced) and replaced with the canonical stub from the harness'sdocs/ADOPTING.md(## The stub, read at?ref=v2):uses: customink/agent-first-standards/.github/workflows/pr-review.yml@v2on: pull_requestwithtypes: [opened, synchronize, ready_for_review, reopened, closed](closedis what the harness needs for lifecycle telemetry)actions: read,contents: read,pull-requests: write,issues: writeverdict_policy: deterministicset explicitlyANTHROPIC_API_KEY,CUSTOM_INK_CODE_REVIEW_APP_ID,CUSTOM_INK_CODE_REVIEW_PRIVATE_KEY,NEW_RELIC_ACCOUNT_ID,NEW_RELIC_INSERT_KEY.claude/review-prompt.md: removed the paragraph "Only comment when you have actionable feedback. Never post "looks good"..." (separate commit). The base prompt already owns review behavior. All domain sections are untouched.Notes
Trust boundary. The harness skips the real review on a PR that edits the review stub, and it restores
CLAUDE.mdfrom the base branch. Soreview / codeon this PR going green does not show the setup works (its review steps are skipped). The new configuration is first exercised on the first PR opened after this merges.Dropped from the legacy workflow (all harness-owned now):
issue_comment,pull_request_review_commentandpull_request_reviewtriggers:@claudein a comment or review body no longer re-triggers a review. A team that wants that should run it as a separate interactive-assistant workflow.--allowedToolslist.vars.CLAUDE_REVIEW_MODELmodel selection. The repo variable is no longer read; the harness's default model applies. Addmodel:underwith:if a specific model is wanted.--max-turns 10. The harness default is 25. Addmax_turns:back if the lower budget was a deliberate cost decision.@claude-mentionif:conditions,concurrencyblock, andcontinue-on-error. The harness has its own concurrency group and draft/bot handling.id-token: write(the harness workflow does not request an OIDC token) andissues: read(nowissues: write).CLAUDE.mdand.claude/review-prompt.mditself. (The legacy step also readAGENTS.md; noAGENTS.mdexists in this repo.)Non-default inputs carried over: none. The only
with:input isverdict_policy: deterministic, written explicitly per org policy. There was no previousverdict_policy(legacy workflow), so no behavior change is being overridden. With it, blocking findings request changes, non-blocking findings post as comments, and a clean review approves.Path filters: none.
review / codecan be made a required check once findings are trustworthy.Sub-directory
CLAUDE.mdfiles: none (only the rootCLAUDE.md), soclaude_md_globis not set.Local dry-run (skill Step 6) was not run.
Review prompt: the remaining "Review Behavior" section ends with "If the entire PR looks good, do not post a comment at all", which may conflict with the harness's
deterministicpolicy (a clean review posts an APPROVE). The team may want to trim that section; it was left as-is here.CODEOWNERS:
* @customink/fenixcovers.github/. Branch protection onmasterrequires 1 approving review;require_code_owner_reviewsis false.Rollout after merge: consider promoting
review / codeto a required check once findings look trustworthy, andreview_mode: blockingif suggestion churn becomes a problem.🤖 Generated with Claude Code