Skip to content

Rename qube fixture to tested_qube (for clarity) - #1983

Open
deeplow wants to merge 1 commit into
mainfrom
2026-11-clear-qube-under-test
Open

deeplow wants to merge 1 commit into
mainfrom
2026-11-clear-qube-under-test

Conversation

@deeplow

@deeplow deeplow commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Follow up to #1966 (comment). Dev change, in case it makes it less confusing.

Workstation test files are generally organized by the qube they test. Some common tests (in base.py) assume the existence of said fixture.

This 'qube' could cause confusion, so renaming it to 'tested_qube' may highlight more the purpose of said fixture.

Test plan

  • visual review
  • tests pass

Checklist

This change accounts for:

  • any necessary RPM packaging updates (e.g., added/removed files, see rpm-build/SPECS/securedrop-workstation-dom0-config.spec)
  • any required documentation

Workstation test files are generally organized by the qube they test.
Some common tests (in base.py) assume the existence of said fixture.

This 'qube' could cause confusion [1], so renaming it to 'tested_qube'
may highlight more the purpose of said fixture.

[1]: https://github.com/freedomofpress/securedrop-workstation/pull/1966/changes#r4585286200
@deeplow
deeplow requested a review from a team as a code owner November 16, 2026 11:46
@deeplow deeplow added the 4.3-openqa-all Run on OpenQA in Qubes 4.3 deploying the journalist workstation combined with the admin workstation label Nov 16, 2026
@deeplow deeplow moved this to Ready For Review in SecureDrop Nov 16, 2026
@deeplow deeplow self-assigned this Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.3-openqa-all Run on OpenQA in Qubes 4.3 deploying the journalist workstation combined with the admin workstation

Projects

Status: Ready For Review

Development

Successfully merging this pull request may close these issues.

1 participant