Repository navigation
Commit fb7f804
committed
Pass the downstream CrossByte suite over its known Int64 test failure
testASmallInt64IsAnInt64WhenWrapped has failed in every downstream run
since at least 10-23, against the same CrossByte commit: "expected 16
but it is 18". It expects an int32 when Std.isOfType(boxed, Int) is
true for Int64.ofInt(5) held in a Dynamic. hxcpp has answered true for
an Int64 in the Int range since 2016, and libhxcpp still does, while
CrossByte's BsonWriter.isInt64, which its encoder goes by, sees the
Int64 box libhxcpp has made of small values since 01d67a2, and writes
an int64, as it should. The test is CrossByte's to fix, by asking
BsonWriter.isInt64(boxed) as the encoder does.
test/downstream/run-suite.sh runs the native suite and passes it with a
warning when every test utest reports as failed is named in
KNOWN_FAILURES, which the workflow sets to this one test with the reason
beside it. A crash, a timeout, a run with no report, or any other
failure fails the step as before.
Tried against the logs of the runs on 10-27 (passes with the warning),
04f436b (fails, naming the five other tests), a run with no failures
and a crash.1 parent b9a4b29 commit fb7f804
2 files changed
Lines changed: 51 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
52 | 61 | | |
53 | 62 | | |
54 | 63 | | |
| 64 | + | |
| 65 | + | |
55 | 66 | | |
56 | 67 | | |
57 | 68 | | |
58 | | - | |
| 69 | + | |
59 | 70 | | |
60 | 71 | | |
61 | 72 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
0 commit comments