Baseline badge mismatch in yari BaselineIndicator (chrome_android partial support flips desktop Chrome icon) #903
|
Filed originally as mdn/content#44856: on Navigator.serial docs, top availability badge shows "not widely supported in Chrome" while compat table below shows full support for Chrome. Confirmed not a content bug. Root cause: BCD api.Navigator.serial:
In yari, client/src/document/baseline-indicator.tsx, the badge groups chrome and chrome_android under one "Chrome" icon and requires both supported via .every(): const supported = (browser: BrowserGroup) => { Since chrome_android only has partial support, the whole Chrome icon flips unsupported, producing the misleading badge text, even though desktop Chrome is fully supported. Fix: check the group's primary (desktop) id only: const supported = (browser: BrowserGroup) => { I have this patched on a branch in my yari fork, ready to submit. But mdn/yari currently restricts PR creation to collaborators and has no public Issues tab, so I cannot submit it there directly. Two questions:
|
Replies: 1 comment
|
https://github.com/mdn/fred is the renderer of this now, however the fix is wrong: the Baseline definition requires a feature to be supported in both desktop and mobile browsers to be considered supported - so it's true that this feature is "not widely supported in Chrome". |
https://github.com/mdn/fred is the renderer of this now, however the fix is wrong: the Baseline definition requires a feature to be supported in both desktop and mobile browsers to be considered supported - so it's true that this feature is "not widely supported in Chrome".