Repository navigation
nvme: Update nvme collector to support api changes in procfs - #3865
Merged
Merged
Conversation
scarlet-storm
marked this pull request as draft
October 22, 2026 09:10
Contributor
Author
|
Depends on prometheus/procfs#889 |
scarlet-storm
force-pushed
the
nvme-optional-nuse
branch
3 times, most recently
from
October 22, 2026 12:14
e84dcd5 to
4b9ef2c
Compare
Member
|
I've cut procfs v0.23.0. If you want to add this to the PR: |
SuperQ
reviewed
Oct 23, 2026
scarlet-storm
force-pushed
the
nvme-optional-nuse
branch
from
October 23, 2026 14:06
4b9ef2c to
6955363
Compare
Signed-off-by: scarlet-storm <12461256+scarlet-storm@users.noreply.github.com>
New procfs api removes the namespace usage fields from the struct and adds a new method for fetching the used blocks. Update the nvme collector to support the changes. Also adds an option to disable nvme namespace usage metric. It is enabled by default and can be disabled if desired via the flag --no-collector.nvme.namespace-usage. A namespace without a nuse file is skipped with a debug message. A read error, for example EIO which can be returned when the controller is not live, is logged and the other namespaces are still collected. Assisted-by: Claude Code (Claude Sonnet 5.5) Signed-off-by: scarlet-storm <12461256+scarlet-storm@users.noreply.github.com>
scarlet-storm
force-pushed
the
nvme-optional-nuse
branch
from
October 23, 2026 14:16
6955363 to
84454dd
Compare
scarlet-storm
changed the title
scarlet-storm
force-pushed
the
nvme-optional-nuse
branch
from
October 23, 2026 14:47
7f008f8 to
04fcb08
Compare
scarlet-storm
marked this pull request as ready for review
October 23, 2026 14:47
scarlet-storm
force-pushed
the
nvme-optional-nuse
branch
from
October 24, 2026 13:52
04fcb08 to
6b45a5d
Compare
fixture update for prometheus/procfs#885 Signed-off-by: scarlet-storm <12461256+scarlet-storm@users.noreply.github.com>
scarlet-storm
force-pushed
the
nvme-optional-nuse
branch
from
October 24, 2026 15:12
6b45a5d to
ec10ca4
Compare
Contributor
Author
|
arm64 was using a different e2e file which was not updated. The arm64 e2e is fixed now |
SuperQ
approved these changes
Oct 24, 2026
SuperQ
left a comment
SuperQ
left a comment
Member
There was a problem hiding this comment.
LGTM.
I'm going to ignore the unrelated linter issue and fix that myself.
SuperQ
enabled auto-merge (squash)
October 24, 2026 17:12
SuperQ
disabled auto-merge
October 24, 2026 17:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The namespace nuse attribute does not exist in older kernels which caused the the nvme collector to fail on kernel < 6.8. The bug is fixed in procfs as part of prometheus/procfs#889 . This PR updates the nvme collector to support the changes made in procfs API.
Assisted-by: Claude Code (Claude Sonnet 5.5)