Skip to content

Commit 9900d65

Browse files
thesujaiTrueForge Agent
andauthored
fix(sandbox-env): configure build script limit (#1278)
Co-authored-by: TrueForge Agent <trueforge@example.org>
1 parent 57ef77a commit 9900d65

6 files changed

Lines changed: 51 additions & 5 deletions

File tree

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@truefoundry/trueforge': patch
3+
'@truefoundry/trueforge-ui': patch
4+
---
5+
6+
Enforce the environment-configured sandbox build-script limit in API requests and hide the limit counter in the environment form.

‎packages/trueforge-ui/src/atoms/environments/EnvironmentFormFields.tsx‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -144,9 +144,7 @@ export function EnvironmentFormFields({
144144
<h3 className="text-sm font-medium text-text-primary">Image And Resources</h3>
145145

146146
<label className="flex flex-col gap-1.5">
147-
<span className="text-xs font-medium text-text-secondary">
148-
Build Script ({values.buildScript.length}/5120)
149-
</span>
147+
<span className="text-xs font-medium text-text-secondary">Build Script</span>
150148
<textarea
151149
className={cn(fieldClassName, 'min-h-24 resize-y font-mono text-xs')}
152150
value={values.buildScript}

‎packages/trueforge/.env.example‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,9 @@ TRUEFORGE_API_KEY=placeholder-value-please-generate-your-own
198198
# SANDBOX_ENVIRONMENT_MEMORY_GIB_MAX=8
199199
# SANDBOX_ENVIRONMENT_DISK_GIB_MAX=10
200200

201+
## Maximum characters accepted in a sandbox environment build script. Default 20,000.
202+
# SANDBOX_ENVIRONMENT_BUILD_SCRIPT_MAX_LENGTH=20000
203+
201204
## Default and max `limit` for list session events / list turn events.
202205
# LIST_EVENTS_PAGE_LIMIT_MAX=100
203206
## Max bytes for an HTTP request body. Default 30 MB.

‎packages/trueforge/src/config.ts‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -768,6 +768,8 @@ export interface SharedServerConfiguration {
768768
SANDBOX_ENVIRONMENT_MEMORY_GIB_MAX: number;
769769
/** Max disk GiB for a sandbox environment. Env: `SANDBOX_ENVIRONMENT_DISK_GIB_MAX`. Default 10. */
770770
SANDBOX_ENVIRONMENT_DISK_GIB_MAX: number;
771+
/** Max characters in a sandbox environment build script. Env: `SANDBOX_ENVIRONMENT_BUILD_SCRIPT_MAX_LENGTH`. Default 20,000. */
772+
SANDBOX_ENVIRONMENT_BUILD_SCRIPT_MAX_LENGTH: number;
771773
/** Default and max `limit` for list session/turn events. Env: `LIST_EVENTS_PAGE_LIMIT_MAX`. Default 100. */
772774
LIST_EVENTS_PAGE_LIMIT_MAX: number;
773775
/**
@@ -1190,6 +1192,11 @@ const shared: SharedServerConfiguration = {
11901192
raw: getEnv('SANDBOX_ENVIRONMENT_DISK_GIB_MAX'),
11911193
defaultValue: 10,
11921194
}),
1195+
SANDBOX_ENVIRONMENT_BUILD_SCRIPT_MAX_LENGTH: parsePositiveInt({
1196+
envKey: 'SANDBOX_ENVIRONMENT_BUILD_SCRIPT_MAX_LENGTH',
1197+
raw: getEnv('SANDBOX_ENVIRONMENT_BUILD_SCRIPT_MAX_LENGTH'),
1198+
defaultValue: 20_000,
1199+
}),
11931200
LIST_EVENTS_PAGE_LIMIT_MAX: parsePositiveInt({
11941201
envKey: 'LIST_EVENTS_PAGE_LIMIT_MAX',
11951202
raw: getEnv('LIST_EVENTS_PAGE_LIMIT_MAX'),

‎packages/trueforge/src/schemas/sandboxEnvironment.ts‎

Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,13 +210,35 @@ function refineSandboxEnvironmentResources(
210210
}
211211
}
212212

213+
function refineSandboxEnvironmentBuildScript(
214+
body: { manifest: z.infer<typeof SandboxEnvironmentManifestRequestSchema> },
215+
ctx: z.RefinementCtx,
216+
): void {
217+
const buildScript = body.manifest.image?.build_script;
218+
if (buildScript !== undefined && buildScript.length > configuration.SANDBOX_ENVIRONMENT_BUILD_SCRIPT_MAX_LENGTH) {
219+
ctx.addIssue({
220+
code: 'custom',
221+
path: ['manifest', 'image', 'build_script'],
222+
message: 'Sandbox environment build script exceeds configured limit',
223+
});
224+
}
225+
}
226+
227+
function refineSandboxEnvironmentRequest(
228+
body: { manifest: z.infer<typeof SandboxEnvironmentManifestRequestSchema> },
229+
ctx: z.RefinementCtx,
230+
): void {
231+
refineSandboxEnvironmentResources(body, ctx);
232+
refineSandboxEnvironmentBuildScript(body, ctx);
233+
}
234+
213235
/** POST create body. */
214236
export const CreateSandboxEnvironmentRequestSchema = z
215237
.object({
216238
manifest: SandboxEnvironmentManifestRequestSchema,
217239
})
218240
.strict()
219-
.superRefine(refineSandboxEnvironmentResources)
241+
.superRefine(refineSandboxEnvironmentRequest)
220242
.openapi('CreateSandboxEnvironmentRequest');
221243

222244
/** PUT create-or-update body. */
@@ -225,7 +247,7 @@ export const UpdateSandboxEnvironmentRequestSchema = z
225247
manifest: SandboxEnvironmentManifestRequestSchema,
226248
})
227249
.strict()
228-
.superRefine(refineSandboxEnvironmentResources)
250+
.superRefine(refineSandboxEnvironmentRequest)
229251
.openapi('UpdateSandboxEnvironmentRequest');
230252

231253
const IsoTimestamp = z.iso.datetime().openapi({ type: 'string', format: 'date-time' });

‎packages/trueforge/tests/unit/apis/sandboxEnvironments.test.ts‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -526,6 +526,16 @@ describe('sandbox environments API → build controller path', () => {
526526
});
527527
}
528528

529+
it.each(['POST', 'PUT'] as const)('%s rejects build scripts above the configured limit', async method => {
530+
const { publicRouter } = await setup();
531+
532+
const response = await writeEnv(publicRouter, { method, build_script: 'x'.repeat(20_001) });
533+
534+
expect(response.status).toBe(400);
535+
const body = (await response.json()) as { error: { message: string } };
536+
expect(body.error.message).toContain('Sandbox environment build script exceeds configured limit');
537+
});
538+
529539
it('stores type equal to the provider outside TrueFoundry mode', async () => {
530540
const { publicRouter, sandboxEnvironmentStore } = await setup();
531541
mockSecretProvider();

0 commit comments

Comments
 (0)