Repository navigation
fix: write local verify reports to local-verifications.jsonl - #302
panshularora wants to merge 1 commit into
Conversation
cmd_verify appended {time, environment, chain_head, checks, result:PASS|FAIL}
into the same verifications.jsonl that published release entries use
({checker, code, driver, gpu, result:MATCH|MISMATCH, segment:int}), mixing
incompatible schemas (issue AOSSIE-Org#211).
Write the local report to local-verifications.jsonl instead so the published
file stays untouched. Update checker_pod.sh and docs/verify.md to match, and
add focused regressions for the schema split.
Fixes AOSSIE-Org#211
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Tip 🎯 Customize your risk assessments
✅ Automatic approvals, with your rules
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Fixes #211
Summary
simple/ovl.py verifywas appending its local report into the sameverifications.jsonlthat published release entries use. Those two shapes are incompatible, so after a localverifythe file mixed schemas and any consumer of the published format could break or misread the new lines.This change makes
verifywrite local results tolocal-verifications.jsonlinstead, leaving the publishedverifications.jsonluntouched.Root cause
Published release entries (one line per segment) look like:
{"checker": "…", "code": "…", "driver": "…", "gpu": "…", "result": "MATCH", "segment": 0}cmd_verifyappended one line per invocation with a different shape:{"time": …, "environment": {…}, "chain_head": "…", "checks": […], "result": "PASS"|"FAIL"}Same path (
run / "verifications.jsonl", opened with"a"), different schema (PASS/FAILvsMATCH/MISMATCH, nestedchecksvs top-levelsegment, nochecker/code/driver).Change
simple/ovl.py: append the local report tolocal-verifications.jsonl.simple/checker_pod.sh: read the local report fromlocal-verifications.jsonl.docs/verify.md: document that local results go tolocal-verifications.jsonland the published file stays unchanged.tests/simple/test_verification_record_schema.py:verifications.jsonlis not appended to byverifyPASS/FAILreport lands inlocal-verifications.jsonlNo chain-format change. No coverage / other bug fixes on this branch.
Test commands and results
Environment:
OVL_DEVICE=cpu(box is CPU-only torch).Per-module counts:
test_verification_record_schematest_simple_verifytest_ovltest_ovl_anchortest_ovl_model_bindingtest_ovl_weights_verdictpytestnot installed on the box)Revert check: temporarily restoring the old
verifications.jsonlwrite path made all 3 new regressions fail again; restoring the fix made them pass.Scope
Addressed Issues:
Fixes #211
Screenshots/Recordings:
Not applicable (no UI changes).
Additional Notes:
Based on upstream
main@f42508c; head27e7250. Local tests: new regressions 3/3 and relevant suite 62/62 pass (see above).AI Usage Disclosure:
We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact. AI slop is strongly discouraged and may lead to banning and blocking. Do not spam our repos with AI slop.
Check one of the checkboxes below:
I have used the following AI models and tools: TODO
Checklist