Repository navigation
Fix install.sh --without-cxx - #393
Merged
Merged
Conversation
It was intended/assumed that GASNet's --without-cxx configure option was sufficient to allow a Caffeine user to deliberately install without a C++ compiler. Unfortunately Caffeine's automatic compiler detection in install.sh was too aggressive in finding and using a C++ compiler in many cases where one was available. Add explicit detection and documentation of --without-cxx to ensure this case works as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was intended/assumed that GASNet's --without-cxx configure option was
sufficient to allow a Caffeine user to deliberately install without a C++ compiler.
Unfortunately Caffeine's automatic compiler detection in install.sh was too
aggressive in finding and using a C++ compiler in many cases where one was
available.
Add explicit detection and documentation of --without-cxx to ensure this
case works as intended.