Skip to content

ci: raise the test-release timeout to fifteen minutes - #242

Merged
paudley merged 3 commits into
mainfrom
paudley/240-test-release-reaches-its-nine-minute
Nov 13, 2026
Merged

paudley merged 3 commits into
mainfrom
paudley/240-test-release-reaches-its-nine-minute

Conversation

@paudley

@paudley paudley commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Raises the hosted test-release job from nine to fifteen minutes, moves the workflow budget gate's bound to match, and states the budget in CONTRIBUTING.md.

Owner ruling, verbatim from the session this change was made in, 2026-11-13: "Raise the limit".

test-release reached its nine-minute limit on several heads. Successful runs took 4m37s to 8m19s (nine passes, slowest 8m19s); stopped runs reached 9m15s to 9m16s. Fifteen minutes gives roughly six minutes of margin over the slowest passing run.

The budget gate's bound moves from one to nine minutes to one to fifteen. It applies to every job, so any job can now declare up to fifteen minutes. No other job's value changes.

Refs #240

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

Warning

Review limit reached

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 83 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0a7e1bc8-e7e3-42b6-bc08-b2ed26ac2f35
Commits

Reviewing files that changed from the base of the PR and between 72b42bc and c2e9515.

Files selected for processing: 7

  • CONTRIBUTING.md
  • docs/capabilities/repository-contract.md
  • tests/repo_gates/ci.rs
  • work/assessments/repository-contract-constraints.md
  • work/assessments/repository-contract-contract.md
  • work/assessments/repository-contract-examples.md
  • work/assessments/repository-contract-explanation.md

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Chores
    • Increased the release test workflow’s timeout from 9 to 15 minutes.
    • Updated the workflow checks to accept timeout values up to 15 minutes. No user-facing changes are included.

The test-release job timeout increases from 9 to 15 minutes. The CI workflow gate now accepts timeout values from 1 through 15, and its error message, comment, and test cases reflect the updated limit.

Changes: Test-release timeout

Layer / File(s) Summary
Align timeout and gate
.github/workflows/ci.yaml, tests/repo_gates/ci.rs
The test-release job timeout increases to 15 minutes. The gate accepts values from 1 through 15, and its test treats 15 as valid and 16 as invalid.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other · Severity of issue fixed: Medium

Possibly related issues

Possibly related PRs

Merge Risk: Minimal · previous review 72b42

This change gives the test-release CI job more time to finish, and the repository check now accepts that limit. It is low risk, and I found no issues blocking merge.

Security architecture risk: Minimal · up to 72b42

The change allows one existing hosted test job six additional minutes without changing its permissions, credentials, triggers, or commands. The timeout remains bounded. No material security risk was identified in this change.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The incremental exposure is up to six additional configured minutes for the existing test-release execution, including execution of pull-request code. The PR does not add another runner, trigger, credential, permission, or deployment step.

Trust Boundaries and Controls

  • observed — The repository-wide execution-budget control is deliberately relaxed, not removed: every checked workflow job must still declare a positive integer timeout no greater than fifteen minutes. The wider policy permits future increases for other jobs but does not apply them automatically.
Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title states the main change: the test-release job timeout is raised from nine to fifteen minutes. The raw summary confirms the workflow timeout change in .github/workflows/ci.yaml and the matchin…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description states the change: raising the hosted test-release job timeout from nine to fifteen minutes, moving the workflow budget gate bound from one-to-nine to one-to-fifteen minutes, and docum…
Full details: Title check

Explanation

The title states the main change: the test-release job timeout is raised from nine to fifteen minutes. The raw summary confirms the workflow timeout change in .github/workflows/ci.yaml and the matching bound update in tests/repo_gates/ci.rs. The title is specific and concise, and it follows the conventional commit prefix style.

Full details: Description check

Explanation

The description states the change: raising the hosted test-release job timeout from nine to fifteen minutes, moving the workflow budget gate bound from one-to-nine to one-to-fifteen minutes, and documenting the budget in CONTRIBUTING.md. It gives timing data from prior runs and cites an owner ruling and issue #240. This matches the changeset summary, which covers the ci.yaml timeout change and the ci.rs gate change. The CONTRIBUTING.md mention is not in the provided summary, but the rest of the description clearly relates to the changes.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the timer’s face
Fifteen minutes now mark the pace
The gate accepts the wider span
The test may finish as it ran
I nibble, then hop off to race

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 39088f48-977f-48ac-bc05-ed0f002fc3af
Commits

Reviewing files that changed from the base of the PR and between e6aa4df and 72b42bc.

Files selected for processing: 2

  • .github/workflows/ci.yaml
  • tests/repo_gates/ci.rs

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

@paudley
paudley merged commit 39c6f77 into main Nov 13, 2026
25 checks passed
@paudley
paudley deleted the paudley/240-test-release-reaches-its-nine-minute branch November 13, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant