Repository navigation
Update CMake - #63
Merged
Merged
Update CMake#63
Conversation
camierjs
reviewed
Jul 28, 2026
5 of 13 tasks
pearce8
approved these changes
Jul 30, 2026
23 tasks done
camierjs
reviewed
Sep 19, 2026
Contributor
Author
|
@camierjs thanks: while your suggestions appear to get ctest passing if applied to the tip of this branch, ctest fails again if I merge |
scheibelp
marked this pull request as draft
October 5, 2026 18:19
camierjs
marked this pull request as ready for review
October 7, 2026 16:13
Member
|
@scheibelp, I updated the expected results: this process could be improved, as these Remhos tests were initially meant for GPU porting. |
Contributor
Author
|
Thanks for updating this! Yes the tests now pass for me locally, |
24 of 55 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With an emphasis on HIP build
ENABLE_LANGUAGE HIPfind_package(HYPRE))The second commit gets ctest passing for me locally with a cmake-based build