Skip to content

Update CMake - #63

Merged
vladotomov merged 5 commits into
CEED:masterfrom
scheibelp:update-cmake
Oct 15, 2026
Merged

vladotomov merged 5 commits into
CEED:masterfrom
scheibelp:update-cmake

Conversation

@scheibelp

Copy link
Copy Markdown
Contributor

With an emphasis on HIP build

  • ENABLE_LANGUAGE HIP
  • Allow choice of Hypre (use find_package(HYPRE))
  • Add explicit Caliper support

The second commit gets ctest passing for me locally with a cmake-based build

@vladotomov
vladotomov requested a review from camierjs July 28, 2026 16:55
Comment thread remhos_tests.cpp Resolved
@pearce8 pearce8 mentioned this pull request Jul 30, 2026
23 tasks done
Comment thread remhos_tests.cpp Resolved
Comment thread remhos_tests.cpp Resolved
Comment thread remhos_tests.cpp Resolved
Comment thread remhos_tests.cpp Resolved
Comment thread remhos_tests.cpp Resolved
Comment thread remhos_tests.cpp Resolved
Comment thread remhos_tests.cpp Resolved
@scheibelp

Copy link
Copy Markdown
Contributor Author

@camierjs thanks: while your suggestions appear to get ctest passing if applied to the tip of this branch, ctest fails again if I merge master into this (I see some baseline values have changed so that may not be surprising). Would you have suggestions on how to address that? I will push the changes up, but they should not be merged as is.

@scheibelp
scheibelp marked this pull request as draft October 5, 2026 18:19
@camierjs
camierjs marked this pull request as ready for review October 7, 2026 16:13
@camierjs

camierjs commented Oct 7, 2026

Copy link
Copy Markdown
Member

@scheibelp, I updated the expected results: this process could be improved, as these Remhos tests were initially meant for GPU porting.
Let me know if it works with your tests too.

@scheibelp

scheibelp commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor Author

Thanks for updating this! Yes the tests now pass for me locally, I will take this out of draft (it was already out of draft)

@pearce8 pearce8 mentioned this pull request Oct 9, 2026
24 of 55 tasks
@vladotomov
vladotomov merged commit 478f71c into CEED:master Oct 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants