Skip to content

Mesh_3 - new facets normal variation criterion - #9855

Open
janetournois wants to merge 21 commits into
CGAL:mainfrom
janetournois:Mesh_3-new_facets_normal_variation_criterion-jtournois
Open

janetournois wants to merge 21 commits into
CGAL:mainfrom
janetournois:Mesh_3-new_facets_normal_variation_criterion-jtournois

Conversation

@janetournois

@janetournois janetournois commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Summary of Changes

This PR :

  • introduces a new meshing criterion, called facet_normals_variation, an upper bound (in degrees) for the angle between the
    normals of two neighbor facets of the complex, separated by a non-complex edge. If the angle is higher, the facets will be refined.
  • introduces the possibility of meshing non-manifold inputs with the manifold criterion. Edges and vertices that belong to the 0D and 1D-complex may be non-manifold, and manifold() will still terminate

Release Management

todo:

  • test demo plugin
  • submit small feature
  • add example
  • add test

@janetournois
janetournois force-pushed the Mesh_3-new_facets_normal_variation_criterion-jtournois branch from 9f5d687 to 8302efa Compare November 16, 2026 16:25
@janetournois
janetournois marked this pull request as ready for review November 17, 2026 14:38
@janetournois

Copy link
Copy Markdown
Member Author

/build:v0

@github-actions

Copy link
Copy Markdown

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9855/v0/Manual/index.html

Comment thread Mesh_3/include/CGAL/Mesh_criteria_3.h Resolved
Comment thread Mesh_3/include/CGAL/Mesh_criteria_3.h Resolved

@lrineau lrineau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have suggestions, and the most important one is about the name of the parameter:

  • facet_normal_angle instead of facet_normals_variation.

Comment thread Mesh_3/include/CGAL/Mesh_criteria_3.h Resolved
janetournois and others added 2 commits November 19, 2026 11:53
Co-authored-by: Laurent Rineau <Laurent.Rineau@cgal.org>
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
Co-authored-by: Laurent Rineau <Laurent.Rineau@cgal.org>
@janetournois

Copy link
Copy Markdown
Member Author

I have suggestions, and the most important one is about the name of the parameter:

  • facet_normal_angle instead of facet_normals_variation.

done :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants