Repository navigation
Mesh_3 - new facets normal variation criterion - #9855
Open
janetournois wants to merge 21 commits into
Open
janetournois wants to merge 21 commits into
janetournois wants to merge 21 commits into
Conversation
… 2 adjacent complex facets that are not separated by a complex edge
checking if 2 neighbor normals have dot product >= 0
to replace scalar product < 0
janetournois
force-pushed
the
Mesh_3-new_facets_normal_variation_criterion-jtournois
branch
from
November 16, 2026 16:25
9f5d687 to
8302efa
Compare
janetournois
marked this pull request as ready for review
November 17, 2026 14:38
Member
Author
|
/build:v0 |
This was referenced Nov 17, 2026
Closed
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9855/v0/Manual/index.html |
afabri
reviewed
Nov 17, 2026
afabri
reviewed
Nov 17, 2026
afabri
reviewed
Nov 17, 2026
lrineau
requested changes
Nov 19, 2026
lrineau
left a comment
Member
There was a problem hiding this comment.
I have suggestions, and the most important one is about the name of the parameter:
facet_normal_angleinstead offacet_normals_variation.
Co-authored-by: Laurent Rineau <Laurent.Rineau@cgal.org>
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com> Co-authored-by: Laurent Rineau <Laurent.Rineau@cgal.org>
lrineau
reviewed
Nov 19, 2026
lrineau
reviewed
Nov 19, 2026
Co-authored-by: Laurent Rineau <Laurent.Rineau@cgal.org>
lrineau
approved these changes
Nov 20, 2026
Member
Author
done :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR :
facet_normals_variation, an upper bound (in degrees) for the angle between thenormals of two neighbor facets of the complex, separated by a non-complex edge. If the angle is higher, the facets will be refined.
manifold()will still terminateRelease Management
todo: