Repository navigation
Mesh_3 - new facets normal variation criterion #9855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
janetournois
wants to merge
21
commits into
CGAL:main
Choose a base branch
from
janetournois:Mesh_3-new_facets_normal_variation_criterion-jtournois
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
cd8d67b
add edges(facet) to T3 for readability
janetournois d5f8d91
add new facet criterion to bound approximate normal variation between…
janetournois bc20a6f
remove duplicate normal() and add debug code
janetournois fd25d10
keep orientation consistent
janetournois 10c9ff0
add Facet_normals_variation_criterion and a simple implementation
janetournois 49e5b01
use angle deviation with compare_angle_3_object()
janetournois 8302efa
add facet_normal_deviation to mesh_3_plugin
janetournois 6074f30
allow edges and vertices from the 1D complex to be non-manifold
janetournois eb16e00
doc
janetournois 7322c0f
doc
janetournois 5f643a9
doc
janetournois a697c22
fix compilation
janetournois 3c4ad5b
favor readability
janetournois eabb8e4
doc : Apply batched suggestions from review
janetournois 4f4baf2
add c3t3() and tr() accessors to improve readability
janetournois b7dc152
keep start_cell instead of start_facet
janetournois cfee3fd
rename facet_normals_variation to facet_normal_angle
janetournois 7a7fb73
strings in the demo (from code review)
janetournois a2f3c26
fix naming in demo
janetournois fe72aa9
add missing edges() function
janetournois 92c8817
use DoubleEdit for facetNormalAngle
lrineau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.