Repository navigation
Improvement of PMP_boolean_operation including parallellization #9635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 131 commits
Commits
Show all changes
153 commits
Select commit
Hold shift + click to select a range
ff86d69
Replace box_intersection per AABB_tree in self_intersection.h and opt…
LeoValque 0c035ca
Solved compile error in debug
LeoValque 348e9c1
Parallellisation of fukter intersection of corefinement
LeoValque a67586d
Correct build error with CGALlab
LeoValque b12ecda
Use combine orientation computation to improve running time
LeoValque 3afc093
Simple parallellization of conncted components in corefinement
LeoValque 03e7749
add ConcurrencyTag to face_graph_output_builder
LeoValque ae886f2
Clean import polyline and fill tm2_to_output_vertices
LeoValque a87f92f
Clean unused lines
LeoValque 94951c7
interior_vertices of patch is now a vector (instead of a set) and all…
LeoValque 300e199
Replace unordered_map per property_map
LeoValque 65e6338
Solved a bug where shared edges are not correctly linked to their new…
LeoValque 1f9c17e
Solved a bug where shared edges are not correctly linked to their new…
LeoValque 66995f0
Merge branch 'PMP-bool_ops' of github.com:LeoValque/cgal into PMP-boo…
LeoValque 05ef55f
Remove left over
LeoValque 315c580
Add postprocess of borders and correct a bug when borders are parts o…
LeoValque 08b49de
Clean warnings and compilation error in debug
LeoValque 13bd6af
Rewrite filter_intersections to consider differents callbacks
LeoValque cb42271
ConcurrencyTag in rebase and clean Callback in intersections_impl
LeoValque 56f665f
Considered non_manifold_feature_map
LeoValque c86415c
Solved a bug with wrong orientation in the output
LeoValque 71c4aa9
Correctly consider VPM in filter_intersections
LeoValque 0c7ced2
does_self_intersect does not support Orthogonal_cut_plane_traits, tra…
LeoValque 2c8c21d
Merge remote-tracking branch 'origin/main' into PMP-bool_ops
LeoValque 17ab517
Solve merge conflict with main
LeoValque 6937cc9
Transfer changement of face_graph_utils into boolean_operation_utils …
LeoValque 968b471
Solved a bug in concurrency execution
LeoValque 1cd9aca
Move specialization of surface_mesh from package Surface_mesh to PMP
LeoValque fe146e9
Remove const to reference of mesh to alloid visitors to modify them
LeoValque 80a599f
Correct bug when doing corefine between a manifold mesh and a non-man…
LeoValque 00ab167
Filter intersections with bbox instead of triangles
LeoValque bb4c172
Correct filtered_callback of corefine
LeoValque 117596d
Correct resize of vectors in append_patches for surface_mesh
LeoValque 254b372
Solve a bug with filter_intersections where the descriptors returned …
LeoValque 82d3b3e
Correct wrong if statement for degenerate faces
LeoValque 9a45376
Treat correctly the case of the faces to test are empty in self_inter…
LeoValque f5078b2
Avoid the copy
afabri 662f7e1
update depencies
LeoValque e6b02f2
Solve bug in the testsuite
LeoValque 74499f8
Replace box_intersection_d per AABB_tree in PMP/intersection.h
LeoValque 503b55c
Remove unused include
LeoValque 1a52c64
Replace box_intersection_d per AABB_tree in intersecting_meshes
LeoValque 21043fc
Apply suggestions
LeoValque d02f46f
Merge remote-tracking branch 'origin/main' into PMP-bool_ops
LeoValque 1421c4a
Solvebug in self-intersection
LeoValque 775a309
Rename callback halfedges
LeoValque 02b88e3
Solved a bug with invalid halfedges if the border of a remove patch h…
LeoValque 2a8e5ee
Reorder callback of autorefine
LeoValque 7f9aa4a
solve a bug of bad border connection when removed a patch
LeoValque 66df6c7
Solve a bug with bad constructing tree
LeoValque 8c8e491
Treat correctly singleton tree
LeoValque 5e486a8
Singleton tree case
LeoValque 2d2b481
Add missing function for singleton tree case
LeoValque 18f675f
Make Throw_at_output and Throw_at_count thread safe
LeoValque 16e82e4
Reintroduce depencies to Box_intersection_d, it is used by PMP_mesh_r…
LeoValque de53663
Add missing function for singleton case
LeoValque 0c3d3b0
resolved ambiguity
soesau f46bdaa
added is_derived_from_Surface_mesh
soesau 23bc3cc
renaming is_derived_from_Surface_mesh to is_Surface_mesh and moving i…
soesau 656a69d
Make specialization compatible with derivation of surface mesh
LeoValque e632019
warning
sloriot 8895de5
Go through face_range instead of all faces of the mesh
LeoValque 8ae2052
Merge branch 'PMP-bool_ops' of github.com:LeoValque/cgal into PMP-boo…
LeoValque 017ec9f
full namespace for IPCP
soesau 49a0207
Add a test to check that output of aabb and box_intersection_d are id…
LeoValque 1f9cf27
Merge branch 'PMP-bool_ops' of github.com:LeoValque/cgal into PMP-boo…
LeoValque 1fc31c6
Fix bug where the specialization was not taken
LeoValque 73a064b
Bench of fill_new_triangle_mesh + parallellization of extract_patch_s…
LeoValque 8ccbe52
Apply suggestions from Laurent review
LeoValque e197a5f
Add ConstructBbox23(Bbox) in the documentation
LeoValque fbb0238
Update AABB_tree/test/AABB_tree/aabb_vs_box_intersection_d_test.cpp
LeoValque b2d0dd1
Merge branch 'PMP-bool_ops' of github.com:LeoValque/cgal into PMP-boo…
LeoValque 6bc7155
Replace set per property_map in connected_component
LeoValque dba32e6
Add are_equal_polygon_soups and are_equal_meshes
LeoValque 530f466
compatibility with fs
sloriot fad5231
Revert "Add are_equal_polygon_soups and are_equal_meshes"
LeoValque 5943404
Merge branch 'PMP-bool_ops' of github.com:LeoValque/cgal into PMP-boo…
LeoValque 80346e2
reorder depencies
LeoValque e002d60
Solve warnings of conversion to std::size_t to SM::size_type
LeoValque d46095f
Add missing def
LeoValque aed7ba1
Add missing concurrency_tag and changes the associate wording in the …
LeoValque ed4734d
Update changes.md
LeoValque f44d569
Benchmark for autorefine and boolop
LeoValque 7acbe0d
Reduce shift of the duplicate in tesrt
LeoValque c1fd3c4
re-add operators for compatibility with exterior code
sloriot 791b561
Add singleton case to self_intersection
LeoValque ac43246
Merge branch 'PMP-bool_ops' of github.com:LeoValque/cgal into PMP-boo…
LeoValque ef85b04
Desactivate enable_if if CGAL_DO_NOT_USE_SURFACE_MESH_SPECIALIZATIONS…
LeoValque e29408a
Update borders of a patch when removing an edge from shared edges
LeoValque b26223d
Remove output building modifications
LeoValque 8db2046
Remove output building modifications
LeoValque 25d97b7
Solved merge conflict with main
LeoValque 02eb118
Solved conflict with main
LeoValque d1595b3
remove surface_mesh_specializations.h
LeoValque 8dca07b
fix filtering of edges
sloriot 0a52acd
cosmetic
sloriot eff08ef
filter faces in sequential mode too
sloriot 17d427e
filter out shared edges in manifold case too
sloriot 982d75a
missing vertex point map
sloriot 65a59d0
avoid reference to dangling transformation
sloriot 81030fb
do not write twice self-intersecting pairs
sloriot 2b90877
restrict the test to collected faces
sloriot 4136b41
handle empty polyline range + restrict bbox to face_range
sloriot d819efa
handle update of output iterator returned
sloriot 16cefdb
remove extra useless call
sloriot 3b1512b
copy/paste error
sloriot f2d8aa0
fix license,, clean up and add TODO
sloriot 80ebee0
hide non-accepted/reviewed APIs
sloriot 6642fe8
remove self-reference
sloriot f10baba
remove leftover no longer used
sloriot 89b8355
cosmetic
sloriot a8db7b2
Make the build compatible with non-random-access ranges
LeoValque b7d2136
Merge branch 'PMP-bool_ops' of github.com:LeoValque/cgal into PMP-boo…
LeoValque 3affed8
missing include
sloriot d994859
Reintroduce polygon_mesh_slicer in PMP benchmark
LeoValque 67e1071
Rewrite parallelisation to avoid std::next(begin, i) potentially expe…
LeoValque 2e99a60
Apply suggestions from the review
LeoValque d670930
missing vpm
sloriot 8d610b7
Complete missing commentaries
LeoValque a31dbce
take a reference so that the output iterator is really updated
sloriot 57eeed2
Remove unnecessary copy
LeoValque 69cbb8a
handle degenerate polylines and missing out it update
sloriot c8edea5
typo: use range size
sloriot 1f088a7
no need to update it, taken by ref
sloriot bd9e2ca
idiom for output iterator wrapping
sloriot dfe442f
even when skipping polylines, index should be registered
sloriot 526dcd9
same fix here too
sloriot 010c707
get rid of internal functions and use AABB_trees::do_intersect() instead
sloriot 8928285
avoid a copy
sloriot 4250455
Solve merge conflict
LeoValque 8859328
Merge branch 'PMP-bool_ops' of github.com:LeoValque/cgal into PMP-boo…
LeoValque aa60b13
Apply batched suggestions from code review
LeoValque 8b09b1b
Move an assertion to CGAL_expensive_assertion()
LeoValque 7966565
Apply suggestions from the review
LeoValque 2f4fc19
Merge branch 'PMP-bool_ops' of github.com:LeoValque/cgal into PMP-boo…
LeoValque a4bf708
Apply suggestions from the review
LeoValque a2fab02
Reintroduce necessary include
LeoValque f951101
() for std::min
LeoValque fb0a691
leftover
sloriot bb629df
auto in a lambda in not in c++17
sloriot 01a7bad
fix concurrency issue
sloriot 6129c09
no need to change the halfedge, let the filter below pick the right one
sloriot 7e8c4e1
init to map to avoid concurrent insert issues
sloriot c2c64ac
one more TODO
sloriot 0055d38
In troduces intersections for polylines and repair CGAL Lab
LeoValque 200054c
Replace EPICK per Simple_cartesian for reference point
LeoValque b07468a
Merge branch 'PMP-bool_ops' of github.com:LeoValque/cgal into PMP-boo…
LeoValque 9c42394
Missing change from EPick to cartesian
LeoValque e8a7fbf
Merge remote-tracking branch 'origin/main' into PMP-bool_ops
LeoValque 00c63fb
Update CHANGES.md
LeoValque 6ae21d6
avoid conversion warning
sloriot 6dac706
Add missing operator for Orthogonal_cut_plane_traits be compatible wi…
LeoValque 3415711
Merge branch 'PMP-bool_ops' of github.com:LeoValque/cgal into PMP-boo…
LeoValque File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.