Skip to content

Aos 2 sweep relocate fix efif - #9881

Open
efifogel wants to merge 2 commits into
CGAL:mainfrom
efifogel:Aos_2-sweep_relocate_fix-efif
Open

efifogel wants to merge 2 commits into
CGAL:mainfrom
efifogel:Aos_2-sweep_relocate_fix-efif

Conversation

@efifogel

Copy link
Copy Markdown
Member

Summary of Changes

Fixed the relocation of features into a new face in the construction visitor of the surface sweep

The visitor took a subcurve index that was not mapped yet for an index of an isolated vertex, when a larger index had already been mapped (indices are not necessarily mapped in the order they are assigned). This happened, for example, when a curve that starts on the left boundary and ends on the top boundary closes a face after a bounded curve below it is inserted, and failed the assertion v != m_invalid_vertex (a segfault with NDEBUG).

This fixes an unreported bug.
I added a test (and I kept changes to a minimum).

Release Management

  • Affected package(s): Arrangement_on_surface_2
  • Issue(s) solved (if any): fix #0000, fix #0000,...
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership: TAU

…visitor of the surface sweep

The visitor took a subcurve index that was not mapped yet for an index of an
isolated vertex, when a larger index had already been mapped (indices are not
necessarily mapped in the order they are assigned). This happened, for
example, when a curve that starts on the left boundary and ends on the top
boundary closes a face after a bounded curve below it is inserted, and failed
the assertion v != m_invalid_vertex (a segfault with NDEBUG). Added a test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant