Repository navigation
Conversation
…visitor of the surface sweep The visitor took a subcurve index that was not mapped yet for an index of an isolated vertex, when a larger index had already been mapped (indices are not necessarily mapped in the order they are assigned). This happened, for example, when a curve that starts on the left boundary and ends on the top boundary closes a face after a bounded curve below it is inserted, and failed the assertion v != m_invalid_vertex (a segfault with NDEBUG). Added a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixed the relocation of features into a new face in the construction visitor of the surface sweep
The visitor took a subcurve index that was not mapped yet for an index of an isolated vertex, when a larger index had already been mapped (indices are not necessarily mapped in the order they are assigned). This happened, for example, when a curve that starts on the left boundary and ends on the top boundary closes a face after a bounded curve below it is inserted, and failed the assertion
v != m_invalid_vertex(a segfault withNDEBUG).This fixes an unreported bug.
I added a test (and I kept changes to a minimum).
Release Management