Repository navigation
Conversation
… surface sweep The assertion that the overlap starts at the current event compared the minimal vertex of the overlap with the event, without setting the boundary conditions that the event comparer reads; they were left over from a previous comparison, and the comparison could fail (e.g., an error in Compare_x_on_boundary_2 with overlapping vertical linear curves). The assertion now sets the boundary conditions and compares the curve end. Added a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixed an assertion on overlaps of curves with common ancestors in the surface sweep
The assertion that the overlap starts at the current event compared the minimal vertex of the overlap with the event, without setting the boundary conditions that the event comparer reads; they were left over from a previous comparison, and the comparison could fail (e.g., an error in
Compare_x_on_boundary_2with overlapping vertical linear curves). Theassertion now sets the boundary conditions and compares the curve end.
This fixes an unreported bug.
I added a test and kept changes to a minimum.
Release Management