Skip to content

Surface sweep 2 overlap assertion fix efif - #9883

Open
efifogel wants to merge 2 commits into
CGAL:mainfrom
efifogel:Surface_sweep_2-overlap_assertion_fix-efif
Open

efifogel wants to merge 2 commits into
CGAL:mainfrom
efifogel:Surface_sweep_2-overlap_assertion_fix-efif

Conversation

@efifogel

Copy link
Copy Markdown
Member

Summary of Changes

Fixed an assertion on overlaps of curves with common ancestors in the surface sweep

The assertion that the overlap starts at the current event compared the minimal vertex of the overlap with the event, without setting the boundary conditions that the event comparer reads; they were left over from a previous comparison, and the comparison could fail (e.g., an error in Compare_x_on_boundary_2 with overlapping vertical linear curves). The
assertion now sets the boundary conditions and compares the curve end.

This fixes an unreported bug.
I added a test and kept changes to a minimum.

Release Management

  • Affected package(s): Arrangement_on_surface_2
  • Issue(s) solved (if any): fix #0000, fix #0000,...
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership: TAU

… surface sweep

The assertion that the overlap starts at the current event compared the
minimal vertex of the overlap with the event, without setting the boundary
conditions that the event comparer reads; they were left over from a
previous comparison, and the comparison could fail (e.g., an error in
Compare_x_on_boundary_2 with overlapping vertical linear curves). The
assertion now sets the boundary conditions and compares the curve end.
Added a test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant