Skip to content

Use a preview transformer's mode when no preview mode is requested #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Canop merged 1 commit into from
Oct 10, 2026
Merged

Use a preview transformer's mode when no preview mode is requested #1225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/preview/preview_state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ impl PreviewState {
&transform.output_path,
None,
&pending_pattern,
preferred_mode,
preferred_mode.or(Some(transform.mode)),
con,
),
None => Preview::new(
Expand Down Expand Up @@ -152,7 +152,7 @@ impl PreviewState {
&transform.output_path,
None,
&self.pending_pattern,
None,
Some(transform.mode),
con,
),
None => Preview::new(
Expand Down Expand Up @@ -293,7 +293,7 @@ impl PanelState for PreviewState {
&transform.output_path,
None,
&self.pending_pattern,
self.preferred_mode,
self.preferred_mode.or(Some(transform.mode)),
con,
),
None => Preview::new(
Expand Down
4 changes: 4 additions & 0 deletions src/preview/preview_transformer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ pub struct PreviewTransform {
pub transformer_id: TransformerId,
/// Path to the generated file
pub output_path: PathBuf,
/// How the generated file is to be previewed, unless another
/// mode is explicitly requested
pub mode: PreviewMode,
}

impl PreviewTransformers {
Expand Down Expand Up @@ -104,6 +107,7 @@ impl PreviewTransformers {
Ok(output_path) => Some(PreviewTransform {
transformer_id,
output_path,
mode: self.transformers[transformer_id.idx].mode,
}),
Err(e) => {
error!(
Expand Down