Repository navigation
the Heavy button showed on Solana, which has no heavy tier - #3529
Merged
Merged
Conversation
…ing it greyed the chart for good The Pooled / Cold start / Heavy toggle was a fixed list. Solana declares keyed and keyed-cold only (Heavy is a Multicall3, EVM pages only), so Heavy asked for a variant nothing writes and the chart sat on the faded public cohort. The toggle now renders only the modes the spec declares.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On /benchmarks/solana-rpc (Private cohort) the toggle offered Pooled / Cold start / Heavy. Solana declares only
keyedandkeyed-cold: Heavy is the Multicall3 probe and exists on the eight EVM chain pages only. Clicking Heavy set#tier=keyed-heavy, no variant exists for it, and the chart stayed greyed on the public cohort with no way to tell why.The toggle list is now filtered by
resolvable(the spec's declared tiers, already passed asresolvableTierssince #3472). EVM pages keep all three buttons; Solana shows Pooled and Cold start.tsc clean,
pnpm lint0 errors.