Repository navigation
feat: show cookieless and unchecked clicks in the CRM outbound table - #3560
Merged
Merged
Conversation
The outbound table gains a column for clicks counted under the ocb_vid cookie (visitor_source = 'go', readers without the analytics cookie) and a warning when clicks were counted while the repeat filter was unavailable (repeat_checked = false), since those may include doubles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What. The CRM outbound table adds a "No analytics cookie" column, counting clicks made under the
ocb_vidcookie that/gosets. It also shows a warning when clicks were counted while the repeat filter was unavailable.Why. Once #3526 ships,
/gocounts readers without the PostHog cookie and flags clicks it could not check for repeats (repeat_checked = false). Without this split, neither group can be told apart in the totals.Tested. The CRM test suite and
tscpass. The HogQL comparestoString(properties.repeat_checked) = 'false', so it works whether PostHog has typed the property as a boolean or not.Risk. The page only reads data. Before #3526 is deployed, both new counts are 0 and the warning stays hidden.
Rollback. Revert this PR.