Repository navigation
two of bench 313's columns said the opposite of what they measure - #3576
Merged
Merged
Conversation
Quotes overall was marked lower-is-better, which tells a reader that quoting less is a virtue. It is not what this page measures and it is not true anywhere else on the site: coverage is better when there is more of it, and the reason that column exists is to explain a score rather than to compete with it. Routed with a reservation carried the same inversion, saying that warning you less wins. The schema has no neutral: higher_is_better is a boolean and omitting it means lower-is-better, so a column that counts a behaviour has to answer whether MORE of that behaviour helps the reader choosing a router. asked more evidence behind a row more is better coverage what it quotes in general more is better screened it refused and named the token more is better reserved it routed and warned you more is better no_liquidity it had nothing to sell you left as it was The headline is untouched and still lower-is-better, because it counts the harm: KyberSwap at 100% routed into all ten failed tokens and is last, not first. Its 98.3% coverage is why, not a second score. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Florent read the board and asked whether KyberSwap was the best. It is last: the headline is lower-is-better and KyberSwap routed into all ten failed tokens. Two columns were pushing him that way.
What was wrong
Quotes overallwas marked lower-is-better, which tells a reader that quoting less is a virtue. It is not what this page measures and it is not true anywhere else on the site: coverage is better when there is more of it, and that column exists to explain a score, not to compete with it.Routed with a reservationcarried the same inversion, saying that warning you less wins.The rule applied
The schema has no neutral (
higher_is_better: z.boolean().default(false)), so a column that counts a behaviour has to answer whether more of that behaviour helps the reader choosing a router.The headline is untouched and still lower-is-better, because it counts the harm.
For the record
KyberSwap at 100% routed into 10 of 10 failed tokens and is last. Its 98.3% coverage is the reason, not a second score: a router that quotes nearly everything routes into nearly every trap without selecting anything. LI.FI leads at 3 of 10 from a 78.7% baseline, which is the one row where the gap between the two columns is real selection.
Cache keys
bench-unfiltered-v190,all-benchmarks-v183(lockstep),bench-filters-v108(both tier tabs sort and colour those panels by the corrected direction).Gates
pnpm validate249 specs valid ·pnpm exec tsc --noEmitclean ·pnpm test1077 pass 0 fail.Deploy
Spec only: worker rebuild then materialize reset.
🤖 Generated with Claude Code