Skip to content

i18n: sync zh/ja/ko and es translations with upstream/main (2026-11-03) - #2226

Closed
lin-bot23 wants to merge 5 commits into
Comfy-Org:mainfrom
lin-bot23:docs/i18n-sync-20261103
Closed

lin-bot23 wants to merge 5 commits into
Comfy-Org:mainfrom
lin-bot23:docs/i18n-sync-20261103

Conversation

@lin-bot23

Copy link
Copy Markdown
Contributor

What this PR does

Daily translation sync of the Comfy-Org/docs locale pages with upstream/main (branch cut from 7066cf438).

Pending pairs this run found

bun .github/scripts/i18n/translate-i18n.ts --dry-run at the start of the run:

  • zh / ja / ko: 78 pending pairs across 26 English pages
  • es: 189 pending pages + 1 snippet (install/update-requirement.mdx)

Batch 1: zh / ja / ko (25 pages x 3 locales = 53 files)

Router reference and per-model code pages, plus the four Router overview pages:

  • development/comfy-router/reference.mdx
  • development/comfy-router/limitations.mdx
  • development/comfy-router/api.mdx
  • development/comfy-router/realtime.mdx (new localized pages: ja, zh, ko)
  • development/comfy-router/models/byteplus/* (7 code pages)
  • development/comfy-router/models/kling/* (8 code pages)
  • development/comfy-router/models/runway/gen4-image/code.mdx
  • development/comfy-router/models/xai/* (4 code pages)

tutorials/partner-nodes/pricing.mdx is also pending for the three locales; it is excluded from this PR
(pricing pages are maintained by hand, not via the translate pipeline).

Repairs applied on top of the machine output

  • glued ### headings onto the preceding paragraph (28 files)
  • glued </ParamField> onto following prose, and one duplicated ParamField block (zh seedance-1-0-pro-fast)
  • untranslated model / id field bodies (5 files), one truncated response section (ja seedance-1-0-pro-250528: 8 ResponseField blocks were dropped, plus model self-talk leaked into the body)
  • localized heading anchors: realtime.mdx (ja/zh), limitations.mdx (ja/zh), reference.mdx links (ja/zh)

Verification

  • check-structure-parity.ts --base=upstream/main → OK (only pre-existing extra-content warnings)
  • verify_content_parity.py on all 53 files → 0 gaps
  • check-anchors.py --only-changed (base upstream/main) → all anchors OK
  • translate-i18n.ts --dry-run for zh/ja/ko after the batch → 0 pending on these pages
  • per-file heading / code-fence / ParamField parity against the English source: equal

es

The es tree still has 189 pending pages. This PR carries the es slice that fits the per-run file budget
(≤150 changed files overall); the remainder is reported for the next run.

@mintlify

mintlify Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Preview approval required

This pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit 3a06776.

Approve preview

@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@lin-bot23

Copy link
Copy Markdown
Contributor Author

Closing this instead of merging: the 2026-11-04 run already shipped the same pages in #2241, and this branch's remaining content is superseded.

What I checked (merged main@f20e7ae into the branch locally; nothing was pushed):

  • The branch is 12 commits behind main and 98 files conflict. Those conflicts are not content disagreements: main already carries the same pages translated (i18n: sync zh/ja/ko and es translations with upstream/main (2026-11-04), i18n: sync zh/ja/ko and es translations with upstream/main (2026-11-04) #2241), so nearly every conflict is a phrasing variant of an already-translated page. Resolving them would land ~2.5k replaced lines of equivalent text.
  • After taking main's side on every conflict, nothing main still wants is left in this branch. The 22 paths it would add are generated locale code pages (pnpm code-pages:gen output) for models main has retired: luma ray-2 / ray-flash-2, openai o1 / o1-pro / o4-mini / gpt-image-1 / gpt-4-1-nano. Their English sources no longer exist, so they would be orphan pages.
  • The branch was never green either: mint-checks fails with Syntax error - Unable to parse es/development/comfy-router/models/byteplus/, check-anchors reports NOT FOUND anchors, and structure-parity fails.

What is genuinely still missing on main: 7 Spanish Router pages under es/development/comfy-router/models/byteplus/ (1-4 pending sections each) were up to date here. I am not carrying them over in this PR; the next scheduled sync translates them from the current English source.

Going forward all translation syncs land in a single PR: if an unmerged i18n PR exists, the run merges main into it, resolves the conflicts in place and appends the new pages; a new PR is only opened when there is none.

@lin-bot23 lin-bot23 closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant