Repository navigation
Conversation
…fixes Remove the single-point eval(const Point &). It located the point by its coordinates, so on a curve visiting the same lattice point twice it estimated the wrong visit and mixed the pencils of both visits; it also scanned the whole segmentation for every call. Points are now identified by their position along the curve. To estimate a single point, call the range eval on [it, it + 1).
… distance filtering Remove the single-point eval(const Point &) from LambdaMST3D. It located the point by its coordinates, so on a curve visiting the same lattice point twice it estimated the wrong visit and mixed the pencils of both visits; it also scanned the whole segmentation for every call. Points are now identified by their position along the curve. To estimate a single point, call the range eval on [it, it + 1).
Remove the single-point eval(const Point &) from LambdaMST by 2D. It located the point by its coordinates, so on a curve visiting the same lattice point twice it estimated the wrong visit and mixed the pencils of both visits; it also scanned the whole segmentation for every call. Points are now identified by their position along the curve. To estimate a single point, call the range eval on [it, it + 1)
LambdaMST3DBy2D needs a range that is functional along one axis, and LambdaMST3D with DSSLengthLessEqualFilter needs a length threshold. LambdaMSTAxisLabeller computes both from the digital curve alone.
…pencils and their reachability
The 2D DSSs of the projections could extend beyond the 3D range, so the main axis and the parameters were read from the wrong lengths. Each projection now has a validity flag (bijective and a 2D DSS), which makes a valid 2D DSS cover exactly [begin(), end()), and the new mainAxis() is read from these flags.
Member
Author
|
Hello everyone! Long time! Another bigger PR with a new curve discrtization method and new curve types is under way. The changes to the DGtalTools are going to be incorporated once these two PRs are merged (this one here and the curves related one). |
Member
Author
|
Seems to be failing now on something not related to the PR. It is eigen fetch problem. I have it also on my machine. Seems like a problem with GitLab. |
Member
Author
|
Should be ready for a review. |
Member
Author
|
@dcoeurjo @JacquesOlivierLachaud normally this should be ready for a review. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Lambda-MST tangent estimators identified points by their coordinates, so a curve visiting the same lattice point twice got a wrong estimate. They now work on positions along the curve.
LambdaMST3DBy2Dcan be run along a whole 3D curve with the newLambdaMSTAxisLabeller.LambdaMST2D/3D/3DBy2D: points identified by position; the rangeevalgives complete pencils at both ends of any sub-range (andLambdaMST2Dno longer writes outside its result on a sub-range).LambdaMST3D: orphan treatment replaced byreach()of the filter; newuncoveredPoints().LambdaMST3DBy2D: newinitwith a wider context; tangents oriented along the traversal and of unit length.Naive3DDSSComputer: a validity flag per projection, so the 2D DSSs no longer extend beyond the 3D range; newmainAxis().LambdaMSTAxisLabeller: axis and runs of a 3D curve, shortest 2D maximal segment (per run and overall) forDSSLengthLessEqualFilter, andevalByRuns().Breaking changes: the single-point
eval(const Point &)is removed from the three estimators (evaluate[it, it + 1));CLMSTDSSFilternow hasoperator()andreach()instead ofadmissibility()andposition();TangentFromDSS3DFunctortakes the eccentricity as (numerator, denominator).This work was prepared with the help of Claude AI, which cleaned up the experimental code, and helped with debugging and documenting the code.
Checklist