Repository navigation
fix: let version-sync skip frozen fixture constants via an ignore marker - #380
Merged
Merged
Conversation
A source-constant line with a version-sync ignore comment is no longer compared to plugin.json. Fixes the standing false positive on FIXTURE_VERSION in tests/test_docs_staleness_prose.py. Red-first tests cover the marked case and an unmarked positive control. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/version-sync.shno longer flags frozen fixture constants. A source-constant line carrying# version-sync: ignoreis skipped, and that marker is applied toFIXTURE_VERSION = "4.5.0"intests/test_docs_staleness_prose.py, which is deliberately frozen (its comment says so) but matched the scan'sVERSION = "x.y.z"pattern. This removes the standingversion-sync.shexit 1 ondev. Unmarked stale constants are still flagged.Evidence
Red first, then green (
bash tests/test_version_sync.sh):Live scan after merging
origin/dev(v4.8.2):scripts/version-sync.sh --quietexits 0 (before: 1, flagging./tests/test_docs_staleness_prose.py (v4.5.0)).Neighbors:
tests/test_version_sync_precommit.shandtests/test_bump_version.shexit 0;tests/test_docs_staleness_prose.pyhas no failures; markdownlint on both changelogs: 0 issues.Notes
# version-sync: ignorecomment, matched in pure bash (no pipe).origin/devto clear CHANGELOG conflicts; squash-merge drops it.🤖 Generated with Claude Code