Skip to content

fix: let version-sync skip frozen fixture constants via an ignore marker - #380

Merged
Data-Wise merged 3 commits into
devfrom
feature/version-sync-ignore-marker
Nov 1, 2026
Merged

Data-Wise merged 3 commits into
devfrom
feature/version-sync-ignore-marker

Conversation

@Data-Wise

Copy link
Copy Markdown
Owner

Summary

scripts/version-sync.sh no longer flags frozen fixture constants. A source-constant line carrying # version-sync: ignore is skipped, and that marker is applied to FIXTURE_VERSION = "4.5.0" in tests/test_docs_staleness_prose.py, which is deliberately frozen (its comment says so) but matched the scan's VERSION = "x.y.z" pattern. This removes the standing version-sync.sh exit 1 on dev. Unmarked stale constants are still flagged.

Evidence

Red first, then green (bash tests/test_version_sync.sh):

before the fix:
  ✗ marked frozen constant is not flagged (expected exit 0, got 1)
  ✓ unmarked stale constant is still flagged (positive control)
  Results: 4 passed, 1 failed
after the fix:
  ✓ marked frozen constant is not flagged
  ✓ unmarked stale constant is still flagged (positive control)
  Results: 5 passed, 0 failed

Live scan after merging origin/dev (v4.8.2): scripts/version-sync.sh --quiet exits 0 (before: 1, flagging ./tests/test_docs_staleness_prose.py (v4.5.0)).
Neighbors: tests/test_version_sync_precommit.sh and tests/test_bump_version.sh exit 0; tests/test_docs_staleness_prose.py has no failures; markdownlint on both changelogs: 0 issues.

Notes

  • The positive control proves the marker is not a blanket pass.
  • The marker is a same-line # version-sync: ignore comment, matched in pure bash (no pipe).
  • Merge commit in this branch merges origin/dev to clear CHANGELOG conflicts; squash-merge drops it.

🤖 Generated with Claude Code

Data-Wise and others added 3 commits October 31, 2026 17:53
A source-constant line with a version-sync ignore comment is no longer compared
to plugin.json. Fixes the standing false positive on FIXTURE_VERSION in
tests/test_docs_staleness_prose.py. Red-first tests cover the marked case and an
unmarked positive control.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Data-Wise
Data-Wise merged commit f5d9484 into dev Nov 1, 2026
6 checks passed
@Data-Wise
Data-Wise deleted the feature/version-sync-ignore-marker branch November 1, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant