[Data-Wise]

Summary

Eight bash test suites no longer leak temp directories. Each defined make_tmpdir and called it as dir=$(make_tmpdir); that runs in a subshell, so its CLEANUP_DIRS+= never reached the parent shell and the EXIT trap removed nothing. Each suite now creates one unique run root in the parent shell (registered for the existing trap) and make_tmpdir makes its directories inside it. A unique root avoids a prefix glob that could delete another run's directories.

Suites: test_branch_guard, test_branch_guard_e2e, test_git_dryrun, test_git_utils, test_insights_improvements_e2e, test_marketplace_e2e, test_no_switch_guard, test_release_skill_e2e. New guard: tests/test_tmpdir_cleanup.sh runs each suite with an isolated TMPDIR and asserts it is empty afterward.

Evidence

Red first (all 8 suites leaked, 114 dirs in the isolated TMPDIR):

✗ test_branch_guard leaked 64 temp dir(s)
✗ test_branch_guard_e2e leaked 10 temp dir(s)
✗ test_git_dryrun leaked 4 temp dir(s)
✗ test_git_utils leaked 6 temp dir(s)
✗ test_insights_improvements_e2e leaked 1 temp dir(s)
✗ test_marketplace_e2e leaked 7 temp dir(s)
✗ test_no_switch_guard leaked 14 temp dir(s)
✗ test_release_skill_e2e leaked 8 temp dir(s)
Results: 0 passed, 8 failed

After the fix (also re-run after merging origin/dev v4.8.2): Results: 8 passed, 0 failed.

No behavior change in the suites: exit codes match the baseline (test_branch_guard, test_branch_guard_e2e, test_git_dryrun, test_git_utils, test_no_switch_guard exit 0; test_insights_improvements_e2e, test_marketplace_e2e, test_release_skill_e2e exit 1 as on dev, tracked in #377). Nothing leaked into the real $TMPDIR. markdownlint on both changelogs: 0 issues.

Notes

• Not run: full pytest (only test shell scripts and changelogs changed).
• Merge commit in this branch merges origin/dev to clear CHANGELOG conflicts; squash-merge drops it.

🤖 Generated with Claude Code