Repository navigation
Exclude validation sanity checks from history - #159
Merged
giovannivolpe merged 1 commit intoOct 28, 2026
Merged
Conversation
foca13
changed the title
foca13
force-pushed
the
ignore-sanity-check-val-history
branch
2 times, most recently
from
October 27, 2026 14:46
37bf164 to
8e9c602
Compare
foca13
force-pushed
the
ignore-sanity-check-val-history
branch
from
October 28, 2026 11:30
8e9c602 to
bc3d174
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lightning automatically runs a validation step before training to avoid crashing in the validation loop sometime deep into a lengthy training loop. Deeplay's LogHistory class (which inherits from L.Callback) counts this step as the fist validation step in the training process, producing untruthful validation curves. It can be seen in the following MNIST example, where the model randomly predicts the digit chosen for the sanity check and the starting validation accuracy is 100%:
wrong, sanity check included as validation step (11 val steps vs 10 train steps), current form
correct, sanity check ignored (10 val steps & 10 train steps), fixed with this PR
This PR adds two lines of code (+ test) that keep the sanity check but don't include it in the training logs.