Repository navigation
Conversation
maartenba
requested review from
Erwinvandervalk and
StuFrankish
and
a balanced review from Copilot
October 26, 2026 09:13
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Destructive-operation guarantees and exact failure contracts need confirmation against the Spaces implementation, which was unavailable for verification.
No open issues 🎉
What changed in this PR
This PR expands the IdentityServer Spaces documentation to explain deprovisioning, recovery, and permanent removal through ISpaceAdmin.
Changes:
- Documents delete, undelete, and purge behavior, including resource reservation and reuse.
- Describes failure results, recovery guarantees, and cleanup responsibilities for separate storage instances.
| File | Description |
|---|---|
astro/src/content/docs/identityserver/spaces/index.mdx |
Adds lifecycle and failure-result guidance and updates the page date. |
Review effort: Balanced
StuFrankish
reviewed
Nov 5, 2026
Co-authored-by: Stu Frankish <stuart.frankish@duendesoftware.com>
maartenba
requested review from
StuFrankish
and
a balanced review from Copilot
November 5, 2026 15:18
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The checkout lacks the ISpaceAdmin implementation and lifecycle tests, leaving the irreversible-purge, reservation-release, retry, and undelete failure guarantees dependent on maintainer verification against the implementation and API contract.
No open issues 🎉
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.