Skip to content

docs: clarify named storage schema APIs - #1308

Merged
maartenba merged 2 commits into
mainfrom
sf/read-issue-https-github-com
Nov 5, 2026
Merged

maartenba merged 2 commits into
mainfrom
sf/read-issue-https-github-com

Conversation

@StuFrankish

@StuFrankish StuFrankish commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Clarify the distinction between IStorageInstanceSchema and IStorageInstanceSchemaFactory.
  • Document named storage-instance migration and schema operations more explicitly.
  • Link the default and named-instance guidance across the Duende Storage pages.

Validation

  • git diff --check passes.
  • Direct Astro build attempted with npm exec -- astro build; it is currently blocked by unresolved entry module astro/entrypoints/prerender.

Copilot AI balanced review requested due to automatic review settings November 5, 2026 15:24
@StuFrankish StuFrankish self-assigned this Nov 5, 2026
@StuFrankish
StuFrankish requested a review from a team November 5, 2026 15:26
@StuFrankish
StuFrankish marked this pull request as ready for review November 5, 2026 15:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

An active documentation finding identifies missing Oxford commas in two passages, contrary to the repository’s style guidelines.

1 open issue
What changed in this PR

This documentation-only PR clarifies how to select schema APIs for default and named Duende Storage instances.

Changes:

  • Explain when to use IStorageInstanceSchema versus IStorageInstanceSchemaFactory.
  • Clarify migration and schema operations for named instances.
  • Connect getting-started and database guidance to the multiple-instance example.
File Description
astro/​src/​content/​docs/​identityserver/​data/​providers/​duende-storage/​multiple-storage-instances.md Adds schema API selection guidance and clarifies per-instance migration.
astro/​src/​content/​docs/​identityserver/​data/​providers/​duende-storage/​getting-started.md Links to guidance for resolving and migrating additional instances.
astro/​src/​content/​docs/​identityserver/​data/​providers/​duende-storage/​databases/​index.mdx Clarifies the schema operations available for named instances.

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 5, 2026 15:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the documentation changes clarifying schema API selection and per-instance migrations.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@StuFrankish
StuFrankish force-pushed the sf/read-issue-https-github-com branch from 4bb42d2 to 62f13ef Compare November 5, 2026 15:31
@maartenba maartenba added the documentation Improvements or additions to documentation label Nov 5, 2026
@maartenba maartenba added this to the 2026-Q4 milestone Nov 5, 2026

@maartenba maartenba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@maartenba
maartenba merged commit cf8ab92 into main Nov 5, 2026
7 checks passed
@maartenba
maartenba deleted the sf/read-issue-https-github-com branch November 5, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants