Repository navigation
Conversation
Owner
|
Thanks. I'll review in the next few weeks. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
maxDecimalPoints: 2, 1150 milliseconds currently renders as “1.14 seconds” and 2300 milliseconds as “2.29 seconds”. Multiplying the count by a power of ten introduces floating-point error just below the integer that is then floored.Shift the decimal exponent through the number's string representation before truncating, then shift it back. Tests cover exact decimal digits, truncation rather than rounding, scientific notation, large counts, and a large decimal-point limit. Changelog and contributor credits follow CONTRIBUTING.md.
Validation: the new truncation regression fails before the fix;
npm testpasses formatting, lint, TypeScript checking, and all 35 tests afterward.