Repository navigation
[uplift] chore: pin packages' dev React to 19 so the version script can't resolve it to 18 - #3167
Merged
Merged
Conversation
…an't resolve it to 18
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Open
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: its lockfile refresh (changeset version && pnpm install --no-frozen-lockfile) resolved every package's auto-installedreactpeer to the website's 18.3.1, so package code loaded React 18 while the root's test tooling used 19 (victory-tooltip: "A React Element from an older version of React")reactpeer listreact: ^19.3.1as a devDependency (root's range), so the lockfile no longer depends on resolution orderreactentries flip to 18.3.1 and victory-tooltip fails; after, only version specifiers change and all tests passoverridesapply to devDependencies too; checked 18.0.0 locally)