Skip to content

[uplift] chore: pin packages' dev React to 19 so the version script can't resolve it to 18 - #3167

Merged
ryan-roemer merged 1 commit into
mainfrom
chore/uplift-react-dev-dependency
Nov 12, 2026
Merged

ryan-roemer merged 1 commit into
mainfrom
chore/uplift-react-dev-dependency

Conversation

@ryan-roemer

Copy link
Copy Markdown
Member
  • Version Packages Version Packages #3161 failed test: its lockfile refresh (changeset version && pnpm install --no-frozen-lockfile) resolved every package's auto-installed react peer to the website's 18.3.1, so package code loaded React 18 while the root's test tooling used 19 (victory-tooltip: "A React Element from an older version of React")
  • The 28 packages with a react peer list react: ^19.3.1 as a devDependency (root's range), so the lockfile no longer depends on resolution order
  • Replayed the version script locally: before, 28 react entries flip to 18.3.1 and victory-tooltip fails; after, only version specifiers change and all tests pass
  • CI's React 18 matrix still works (its overrides apply to devDependencies too; checked 18.0.0 locally)
  • devDependencies only, no changeset; AGENTS.md notes why

@vercel

vercel Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
victory Ready Ready Preview Nov 12, 2026 7:40pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2ac60d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ryan-roemer
ryan-roemer merged commit 76a1544 into main Nov 12, 2026
8 checks passed
@ryan-roemer
ryan-roemer deleted the chore/uplift-react-dev-dependency branch November 12, 2026 19:50
@ryan-roemer ryan-roemer mentioned this pull request Nov 12, 2026

This branch was successfully deployed

1 active deployment
Preview — 2ac60d6f Deployed Nov 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant