Skip to content

ci: create actions lockfile - #10072

Closed
ArthurKun21 wants to merge 2 commits into
FreeTubeApp:developmentfrom
ArthurKun21:ci/create-actions-lock
Closed

ArthurKun21 wants to merge 2 commits into
FreeTubeApp:developmentfrom
ArthurKun21:ci/create-actions-lock

Conversation

@ArthurKun21

@ArthurKun21 ArthurKun21 commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other - CI

Related issue

Description

This essentially adds a lockfile for github actions to centralized the sha pinning for security and management.

Downside is that you need github cli and install the actions-lock extension. Every time you need to add a new step that needs github actions (e.g. actions/checkout) you need to run

gh actions-lock

Also added the .github/workflows/verify-lockfile.yml that runs every time the dev change the github workflow to remind you if you forgot to update the actions lockfile

https://github.com/github/gh-actions-lock/blob/main/.github/workflows/verify-lockfile.yml

Screenshots

Testing

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

https://github.blog/changelog/2026-10-14-github-actions-workflow-lockfiles-in-public-preview/

https://github.com/cli/cli

https://github.com/github/gh-actions-lock

gh extension install github/gh-actions-lock
gh actions-lock

@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 6, 2026
@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) November 6, 2026 11:49
auto-merge was automatically disabled November 6, 2026 13:34

Head branch was pushed to by a user without write access

@ArthurKun21
ArthurKun21 force-pushed the ci/create-actions-lock branch from b1a1901 to 3c94378 Compare November 6, 2026 13:34
@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) November 6, 2026 13:34
@efb4f5ff-1298-471a-8973-3d47447115dc

efb4f5ff-1298-471a-8973-3d47447115dc commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Im not sure i see any upside to this but i could misinterpret this. It is more meant for workflows that use something like

uses: actions/checkout@v3

but we dont use that anymore. so the only maybe upside would be that its all maintained in one file? but the downside to that is that dependabot will conflict allot on PR's?

@ArthurKun21

ArthurKun21 commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor Author

Im not sure i see any upside to this but i could misinterpret this. It is more meant for workflows that use something like

uses: actions/checkout@v3

It won't be using the actions/checkout@v3 it would be like the latest one from v3 like for example actions/checkout@v3.0.1

maintained in one file?

yea it is now maintained on one file and it would do the checking by itself like the current commit sha so you can just use the v3.0.01 instead of having to copy the sha too

another upside was checking the nested dependencies like for example https://github.com/ArthurKun21/FreeTube/blob/3c94378c06b0829bf9cc29ac46f0ce9e4c0316fc/.github/workflows/actions.lock#L49-L55

    'actions-rust-lang/setup-rust-toolchain@v2.0.1':
        ref: 'v2.0.1'
        commit: 'sha1-a188e68d0fd2bd36ad51dccb2b07ba6e75105f30'
        owner_id: 103899579
        repo_id: 482610590
        uses:
            - 'swatinem/rust-cache@d1527c8f67ef9af357290475d4af4b0fab8f12e0'

but the downside to that is that dependabot will conflict allot on PR's?

the dependabot is already handling it well enough, this is a sample from my project https://github.com/ArthurKun21/fga-data-parser/pull/33/changes

image

auto-merge was automatically disabled November 9, 2026 12:41

Head branch was pushed to by a user without write access

@ArthurKun21
ArthurKun21 force-pushed the ci/create-actions-lock branch from 3c94378 to 02d0f20 Compare November 9, 2026 12:41
@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) November 9, 2026 12:42
@efb4f5ff-1298-471a-8973-3d47447115dc

Copy link
Copy Markdown
Member

The biggest benefit of workflow lockfiles is ensuring dependencies are pinned to immutable commit SHAs. FreeTube already does this manually in its workflow YAML files.

One of the benefits might be dependencies of dependencies but that's not really an issue for us

As this feature is currently in beta, we would like to wait at least a few months after it has reached 1.0

Therefore im closing this PR for the moment and we'll reevaluate when this feature is considered stable

auto-merge was automatically disabled November 10, 2026 15:31

Pull request was closed

@github-actions github-actions Bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants