Repository navigation
Conversation
|
The dynamic scrolling speed seems a bit inconsistent, it is slow, then very fast, then fast 2026-11-20.16-44-40.mp4 |
|
If I drag'n'drop the video over the task bar, the scroll goes backward 2026-11-20.16-47-58.mp4 |
|
On small window's width, dragging a video to the bottom scroll the whole page 2026-11-20.16-55-02.mp4 |
absidue
left a comment
There was a problem hiding this comment.
As this seems to be a new drag and drop implementation, separate from the one that the playlist page uses, could you please either explain why we need two separate ones or deduplicate the code and use either of the implementations for both places.
Another thing to note is that link dragging, specifically for the title link and channel name link were intentionally kept in the playlist page implementation to avoid regressing an existing feature, could you please do the same here?
The long-term plan would be to consolidate much of their behaviors under this implementation. I kept it out of this PR to avoid increasing its size, but I can do that if you would prefer. The rationale for the new one is that it has many subtle behavioral differences through testing to match YT's implementation for both increased fidelity and improved UX, like accelerated scrolling past a certain threshold, adjusted horizontal drag handling, surviving playback changes, not saving temporary drags that are aborted. The only issue is that they might need some different handling by necessity since the user playlist page in grid view has different behaviors and testing needs for identifying and dragging, e.g., horizontally into rows and columns. It also, on YT and FT, has larger video entries on the user playlist page, so it makes more sense to only allow drag-and-drop on the handle portion there.
This does has merit, but I do want to hear broader input from the team before confirming, as this behavior puts it in conflict with fidelity to YT's implementation, which doesn't have this behavior for playlists. From a UX perspective, I worry it could be frustrating if users click on the title section and end up only dragging the title. To provide a bit more edification for that, that feature exists on the User Playlist summary page for YT as well, but not on their watch page. |
Pull Request Type
Related issue
#9469 - faster scroll logic added in this PR could be applied to the User Playlist page as well
#547 - soft prerequisite
Description
Implements drag and drop UI/UX for user playlists with
Customsort enabled. It's built to match most/all of the conveniences the YT drag and drop offers, including faster scrolling speed when dragging sufficiently high/low enough above the Watch Video Playlists box, visibly "extracting" the grabbed video list element, and visibly swapping the positions during the drag.The behaviors all feel pretty nice and have a high degree of fidelity to the YT implementation, so please cross-reference with that on any of your behavioral nitpicks before posting (although I wouldn't expect very many).
Screenshots
Testing
For testing, you need to set your playlist
Sort BytoCustomfirst.Esccancels the attempted dragDesktop
Additional context
@vue-dnd-kit/core, but it was a larger increase in the bundle size, didn't sizably reduce maintainability concerns, and still lacked some fundamental behaviors in the UX that makes YT's (and our current PR's) so much crisper & more satisfying to use. The drag and drop composable with geometry helpers at least help keep this more maintainable & ideally reusable to other places in the code in the future we may want to apply it in part or whole (e.g., for tweaks to the User Playlist page drag and drop).v-memobecause it produced a small but meaningful reduction in latency for drag-and-drop swapping in larger playlists from my testing.