Skip to content

Fix: (Local API) Comment threads not working when depth > 1 - #10152

Open
Shadorc wants to merge 1 commit into
FreeTubeApp:developmentfrom
Shadorc:fix/comment-threads
Open

Shadorc wants to merge 1 commit into
FreeTubeApp:developmentfrom
Shadorc:fix/comment-threads

Conversation

@Shadorc

@Shadorc Shadorc commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #10101

Description

YouTube has removed the number of replies from its UI, it now only shows "Show/Hide reply/replies" for sub-threads.
I've fixed the logic to rely on hasReplyToken too but we end up with a problem: we don't know if we should display singular or plural form.
I didn't want to rely on parsing the string returned by YouTube because it could easily break, so I went with plural form by default.
Let me know if you have better ideas.

This fix is only for local API, Invidious API (and instances) is still broken.

Testing

  1. Go to a video with many comments/sub-threads (e.g. https://youtu.be/W4PIkmjwGsQ)
  2. Check that you can see all sub-threads, no matter the depth
  3. Check that only the first comment show the number of replies
  4. Check that it shows "Show replies" and "Hide replies" for sub-threads

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) November 20, 2026 23:15
@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: waiting for review For PRs that are complete, tested, and ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Comment threads seem to be missing

3 participants