Skip to content

Fix cramped profile assignment dropdown menu - #9986

Open
Samyra312007 wants to merge 6 commits into
FreeTubeApp:developmentfrom
Samyra312007:fix-issue-9901
Open

Samyra312007 wants to merge 6 commits into
FreeTubeApp:developmentfrom
Samyra312007:fix-issue-9901

Conversation

@Samyra312007

@Samyra312007 Samyra312007 commented Oct 26, 2026 •

Copy link
Copy Markdown

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #9901

Description

The profile assignment dropdown next to the subscribe/unsubscribe button was limited to 200px in height (about 4 profiles) and was only as wide as the button itself (about 148px), so most profile names were cut off when many profiles existed.

This increases the dropdown's maximum height to min(60vh, 500px) and gives it a minimum width of 250px (matching the existing profile selector), so more profiles are visible at once and names are no longer truncated. overflow-y is also changed from scroll to auto so a scrollbar only appears when needed.

Following reviewer feedback, this also:

  • Adds a native tooltip (title) to each profile name so the full name is always viewable on hover.
  • Adds a small gap and rounded corners between the subscribe button and the dropdown, instead of squaring off the button's bottom corners, which looked awkward once the dropdown no longer matched the button width.
  • Adds a media query at the 680px breakpoint that reduces the dropdown minimum width to 180px and lets profile names wrap to multiple lines instead of being truncated on mobile.
  • Restores the vertical gap between profile rows on mobile (min-block-size: 50px) after a previous revision collapsed rows to 40px and removed the spacing between profiles.

Screenshots

Desktop: before (148×200px, ~4 profiles visible, long names truncated)

Desktop before: 148x200px, 4 profiles visible, names truncated

Desktop: after (250×480px, more profiles visible, scrollbar only when needed)

Desktop after: 250x480px, more profiles visible, full names with tooltips

Desktop: gap between subscribe button and dropdown (rounded corners retained)

Button and dropdown with small gap and rounded corners

Desktop: native tooltip on hover shows full profile name

Tooltip showing full profile name on hover

Mobile (≤680px): long names wrap, no page overflow

Mobile dropdown with wrapped long profile names

Mobile: vertical gap between profiles: before vs after latest fix

Previous revision used block-size: auto without a minimum, which collapsed single-line rows from 50px to 40px and removed the visual gap between profiles. Restored with min-block-size: 50px.

Before (rows collapsed to 40px, profiles touching):

Mobile before gap fix: rows collapsed, no vertical gap

After (rows keep 50px minimum, gap restored, wrapped names still grow):

Mobile after gap fix: 50px min row height, vertical gap restored

Testing

  1. Create several profiles, including some with long names.
  2. Subscribe to a channel and open the profile assignment dropdown next to the subscribe/unsubscribe button.
  3. Verify that more profiles are visible at once, that profile names are no longer cut off, and that hovering a name shows its full text.
  4. Verify the button keeps its rounded corners and there is a small gap above the dropdown.
  5. Resize below 680px and verify names wrap, the dropdown does not overflow the page, and profiles keep vertical spacing.

Verified locally in Electron (dev build, CDP metrics) at 1280×800 and 390×844 with 13 profiles:

Check Before After
Desktop dropdown size 148×200px 250×480px
Desktop rows visible ~4 ~9
Desktop row height 50px 50px
Button → dropdown gap 0 (squared corners) ~3–4px, rounded corners
Native title tooltip none full profile name
Mobile dropdown width 250px (overflowed) 180px
Mobile long names truncated / cut off wrap, full text visible
Mobile single-line row height 40px (gap removed) 50px (gap restored)
Mobile wrapped-name overlap yes (fixed 50px) no (auto + min-block-size)

Lint: stylelint passes on FtSubscribeButton.css.

Desktop

  • OS: Ubuntu
  • OS Version: 24.04.5 LTS
  • FreeTube version: 0.25.3 beta

Mobile responsive behavior

Following further review, the 250px minimum width overflows narrow/mobile screens and long profile names get cut off the page. Added a media query at the 680px breakpoint (consistent with the rest of the codebase) that reduces the dropdown minimum width to 180px and lets profile names wrap to multiple lines instead of being truncated, so the full name remains visible on mobile. The profile row height grows to fit wrapped names via block-size: auto while min-block-size: 50px preserves the original vertical gap between profiles.

Increase the dropdown's maximum height and minimum width so more profiles are visible at once and long profile names are no longer cut off.
@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 26, 2026
@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) October 26, 2026 19:03
@efb4f5ff-1298-471a-8973-3d47447115dc

Copy link
Copy Markdown
Member

Hi @Samyra312007 as this involves a visual change, could you also include some before and after screenshots

@Shadorc

Shadorc commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

I've tested it and it works well
I have two suggestions, that are nice-to-have imo but are not blocking:

  1. It would be cool to have a tooltip when hovering truncated names (and probably all names, to be consistent), so that they can be viewable in their entirety. I think a simple tooltip, same as buttons, would be sufficient, nothing fancy
image
  1. There is a slight animation when clicking on the arrow icon in the subscribe button. The rounded angles become square, to match with the dropdown, but now that the dropdown does not match the width of the button at all, it is a bit weird. I think there could be a slight space between them, and maybe make them both rounded, I don't know. Feel free to experiment, or to ignore this suggestion. To give an idea of what I'm talking about, I think GitHub's dropdowns are a good example
image

@Samyra312007

Copy link
Copy Markdown
Author

I've tested it and it works well I have two suggestions, that are nice-to-have imo but are not blocking:

  1. It would be cool to have a tooltip when hovering truncated names (and probably all names, to be consistent), so that they can be viewable in their entirety. I think a simple tooltip, same as buttons, would be sufficient, nothing fancy
image 2. There is a slight animation when clicking on the arrow icon in the subscribe button. The rounded angles become square, to match with the dropdown, but now that the dropdown does not match the width of the button at all, it is a bit weird. I think there could be a slight space between them, and maybe make them both rounded, I don't know. Feel free to experiment, or to ignore this suggestion. To give an idea of what I'm talking about, I think GitHub's dropdowns are a good example image

Will update this as soon as possible.

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Oct 27, 2026
Add native tooltips to profile names so full names are visible on hover, and add a small gap plus rounded corners between the subscribe button and the dropdown to avoid the awkward squared-corner animation.
auto-merge was automatically disabled October 27, 2026 19:37

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) October 27, 2026 19:37
@ozrendev

Copy link
Copy Markdown
Contributor

When in mobile view with a long profile name, it will get cut off the page
Maybe we could return to truncating in mobile view?

2026-10-30_15-29-52

Reduce the gap between the subscribe button and the dropdown from 4px to a -7px overlap as suggested in review.
auto-merge was automatically disabled November 1, 2026 15:04

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) November 1, 2026 15:04
@efb4f5ff-1298-471a-8973-3d47447115dc

Copy link
Copy Markdown
Member

When in mobile view with a long profile name, it will get cut off the page Maybe we could return to truncating in mobile view?

It indeed needs some attention. Unsure what the best route to take it is

@efb4f5ff-1298-471a-8973-3d47447115dc

Copy link
Copy Markdown
Member

@Samyra312007 @Shadorc do you have any ideas

@Shadorc

Shadorc commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Maybe this could break the word, going to a new line, even when this is one long word?

@ozrendev

Copy link
Copy Markdown
Contributor

Maybe this could break the word, going to a new line, event when this is one long word?

I think this is the best idea, the profile icon/circle is large enough to easily fit a few more lines of text and still look good

It could theoretically make a very large horizontal chunk of text, but only in the very rare instance where the profile name is super long

@Samyra312007

Copy link
Copy Markdown
Author

Thanks for the review @ozrendev and @efb4f5ff-1298-471a-8973-3d47447115dc!

I've looked at the mobile view issue where long profile names get cut off the page. The problem is that the dropdown has inline-size: max(calc(100% - 10px), 250px) which makes it at least 250px wide, but on mobile there may not be enough space.

Here's my suggestion to fix this - adding responsive behavior for mobile:

In FtSubscribeButton.css, update .profileDropdown and add a media query:

@media (max-width: 600px) {
  .profileDropdown {
    inline-size: max(calc(100% - 10px), 180px);
    .profileName {
      white-space: normal;
      word-break: break-word;
      overflow-wrap: anywhere;
    }
  }
}

This would:

  1. Reduce the minimum width to 180px on mobile screens
  2. Allow profile names to wrap to multiple lines instead of being truncated
  3. Use overflow-wrap: anywhere to break long words if needed

Alternatively, we could also consider using max-inline-size: calc(100vw - 20px) to cap the dropdown width to the viewport width minus some padding.

What do you think about this approach? Should I push this change?

@ozrendev

Copy link
Copy Markdown
Contributor

@Samyra312007 Thanks for the detailed reply, only thing I see is that the mobile breakpoint is usually defined a bit wider at @media (max-width: 680px)

I'd say keep it consistent with a fixed width, not viewport. Push the changes and we can test it out!

On narrow/mobile screens the dropdown's 250px minimum width overflows the
viewport and long profile names get cut off the page. Add a media query at
the 680px breakpoint (consistent with other components) that reduces the
dropdown minimum width to 180px and lets profile names wrap to multiple lines
instead of being truncated, so the full name remains visible.
auto-merge was automatically disabled November 20, 2026 13:05

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) November 20, 2026 13:05
@Shadorc Shadorc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 20, 2026

@Shadorc Shadorc left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Names that are too long overlap with other profiles

image

@Shadorc Shadorc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Nov 20, 2026
On narrow screens, wrapped profile names overflowed the fixed 50px row
height and overlapped neighboring profiles. Let the profile row height
grow to fit the wrapped name (block-size: auto, align-items: flex-start)
so names no longer overlap.
auto-merge was automatically disabled November 20, 2026 17:20

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) November 20, 2026 17:21
@Shadorc Shadorc added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Nov 20, 2026

@Shadorc Shadorc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last fix has removed vertical gap between profiles

image

@Shadorc Shadorc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Nov 20, 2026
block-size: auto collapsed rows from 50px to the 40px color option
height, removing the vertical gap between profiles. Use min-block-size:
50px instead so rows keep their original spacing while still growing
to fit wrapped profile names.
auto-merge was automatically disabled November 21, 2026 09:20

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) November 21, 2026 09:20
@Samyra312007

Copy link
Copy Markdown
Author

Last fix has removed vertical gap between profiles

image

I am really sorry for the inconvenience caused due to this change. Actually i checked it locally and it was working fine.

@Samyra312007

Copy link
Copy Markdown
Author

Updated PR description with latest screenshots of my local changes which was recently i pushed to the PR.

@Shadorc Shadorc added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Nov 21, 2026

@Shadorc Shadorc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking, this issue was still present before those changes. Also, not sure if such resolutions are used and what could be a good solutions, but there are cases where the dropdown can be taller than the window, leading to some profiles not being shown.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: waiting for review For PRs that are complete, tested, and ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Profile Assignment drop-down menu is too cramped

4 participants