Repository navigation
Fix cramped profile assignment dropdown menu - #9986
Samyra312007 wants to merge 6 commits into
Conversation
Increase the dropdown's maximum height and minimum width so more profiles are visible at once and long profile names are no longer cut off.
|
Hi @Samyra312007 as this involves a visual change, could you also include some before and after screenshots |
Add native tooltips to profile names so full names are visible on hover, and add a small gap plus rounded corners between the subscribe button and the dropdown to avoid the awkward squared-corner animation.
Head branch was pushed to by a user without write access
Reduce the gap between the subscribe button and the dropdown from 4px to a -7px overlap as suggested in review.
Head branch was pushed to by a user without write access
It indeed needs some attention. Unsure what the best route to take it is |
|
@Samyra312007 @Shadorc do you have any ideas |
|
Maybe this could break the word, going to a new line, even when this is one long word? |
I think this is the best idea, the profile icon/circle is large enough to easily fit a few more lines of text and still look good It could theoretically make a very large horizontal chunk of text, but only in the very rare instance where the profile name is super long |
|
Thanks for the review @ozrendev and @efb4f5ff-1298-471a-8973-3d47447115dc! I've looked at the mobile view issue where long profile names get cut off the page. The problem is that the dropdown has Here's my suggestion to fix this - adding responsive behavior for mobile: In @media (max-width: 600px) {
.profileDropdown {
inline-size: max(calc(100% - 10px), 180px);
.profileName {
white-space: normal;
word-break: break-word;
overflow-wrap: anywhere;
}
}
}This would:
Alternatively, we could also consider using What do you think about this approach? Should I push this change? |
|
@Samyra312007 Thanks for the detailed reply, only thing I see is that the mobile breakpoint is usually defined a bit wider at I'd say keep it consistent with a fixed width, not viewport. Push the changes and we can test it out! |
On narrow/mobile screens the dropdown's 250px minimum width overflows the viewport and long profile names get cut off the page. Add a media query at the 680px breakpoint (consistent with other components) that reduces the dropdown minimum width to 180px and lets profile names wrap to multiple lines instead of being truncated, so the full name remains visible.
Head branch was pushed to by a user without write access
On narrow screens, wrapped profile names overflowed the fixed 50px row height and overlapped neighboring profiles. Let the profile row height grow to fit the wrapped name (block-size: auto, align-items: flex-start) so names no longer overlap.
Head branch was pushed to by a user without write access
block-size: auto collapsed rows from 50px to the 40px color option height, removing the vertical gap between profiles. Use min-block-size: 50px instead so rows keep their original spacing while still growing to fit wrapped profile names.
Head branch was pushed to by a user without write access
|
Updated PR description with latest screenshots of my local changes which was recently i pushed to the PR. |









Pull Request Type
Related issue
closes #9901
Description
The profile assignment dropdown next to the subscribe/unsubscribe button was limited to 200px in height (about 4 profiles) and was only as wide as the button itself (about 148px), so most profile names were cut off when many profiles existed.
This increases the dropdown's maximum height to
min(60vh, 500px)and gives it a minimum width of 250px (matching the existing profile selector), so more profiles are visible at once and names are no longer truncated.overflow-yis also changed fromscrolltoautoso a scrollbar only appears when needed.Following reviewer feedback, this also:
title) to each profile name so the full name is always viewable on hover.min-block-size: 50px) after a previous revision collapsed rows to 40px and removed the spacing between profiles.Screenshots
Desktop: before (148×200px, ~4 profiles visible, long names truncated)
Desktop: after (250×480px, more profiles visible, scrollbar only when needed)
Desktop: gap between subscribe button and dropdown (rounded corners retained)
Desktop: native tooltip on hover shows full profile name
Mobile (≤680px): long names wrap, no page overflow
Mobile: vertical gap between profiles: before vs after latest fix
Previous revision used
block-size: autowithout a minimum, which collapsed single-line rows from 50px to 40px and removed the visual gap between profiles. Restored withmin-block-size: 50px.Before (rows collapsed to 40px, profiles touching):
After (rows keep 50px minimum, gap restored, wrapped names still grow):
Testing
Verified locally in Electron (dev build, CDP metrics) at 1280×800 and 390×844 with 13 profiles:
titletooltipauto+min-block-size)Lint:
stylelintpasses onFtSubscribeButton.css.Desktop
Mobile responsive behavior
Following further review, the 250px minimum width overflows narrow/mobile screens and long profile names get cut off the page. Added a media query at the 680px breakpoint (consistent with the rest of the codebase) that reduces the dropdown minimum width to 180px and lets profile names wrap to multiple lines instead of being truncated, so the full name remains visible on mobile. The profile row height grows to fit wrapped names via
block-size: autowhilemin-block-size: 50pxpreserves the original vertical gap between profiles.