Repository navigation
Conversation
This avoids boxing the string which causes it to fail strict equality checks, breaking edge cases when using switch statements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new String()on javascript creates a boxed string, which makes it fail on strict equality. This caused inconsistent edge cases with switch statements, as reported in: #9623. Haxe sometimes generates if statements for simple switches, which worked fine, but when it generated a real native switch statement it wouldn't work correctly.We can turn
new String()intoString()(using @:selfCall), which creates a normal string primitive instead of an object: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/String#return_valueThe mozilla docs also say:
Type.createInstanceis handled as well, butType.createEmptyInstancecreates a completely broken value currently: #13164