Repository navigation
Conversation
palas
requested review from
Jimbo4350,
carbolymer,
disassembler and
kevinhammond
as code owners
November 5, 2026 02:20
palas
force-pushed
the
friendly-sep-subtx
branch
from
November 5, 2026 02:20
78c41b5 to
d676bb2
Compare
transaction view
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the changes adding standalone signed and unsigned sub-transaction viewing.
No open issues 🎉
What changed in this PR
Extends transaction view to inspect standalone signed and unsigned Dijkstra sub-transactions through the existing CLI, supporting the broader sub-transaction implementation effort.
Changes:
- Adds a shared reader for transaction and sub-transaction envelopes.
- Supports sub-transactions with both
--tx-fileand--tx-body-file, omitting witnesses for the latter. - Adds signed and unsigned golden tests and a changelog entry.
| File | Description |
|---|---|
cardano-cli/test/cardano-cli-golden/Test/Golden/Debug/TransactionView.hs |
Adds standalone signed and unsigned sub-transaction tests. |
cardano-cli/test/cardano-cli-golden/files/golden/dijkstra/transaction-view-unsigned-sub-tx.yaml |
Records expected unsigned output without witnesses. |
cardano-cli/test/cardano-cli-golden/files/golden/dijkstra/transaction-view-signed-sub-tx.yaml |
Records expected signed output with witnesses. |
cardano-cli/src/Cardano/CLI/Read.hs |
Adds the shared transaction/sub-transaction envelope reader. |
cardano-cli/src/Cardano/CLI/EraIndependent/Debug/TransactionView/Run.hs |
Routes both input options to the appropriate renderer. |
cardano-cli/src/Cardano/CLI/Compatible/Json/Friendly.hs |
Exposes sub-transaction rendering for JSON and YAML output. |
.changes/20261104_173730_cardano-cli_pablo.lamela_view_sub_tx_files.yml |
Documents the expanded input support. |
Review effort: Balanced
10 of 24 tasks
palas
force-pushed
the
friendly-sep-subtx
branch
from
November 5, 2026 19:53
d676bb2 to
0bac3be
Compare
Jimbo4350
requested changes
Nov 6, 2026
palas
force-pushed
the
friendly-sep-subtx
branch
from
November 6, 2026 14:25
0bac3be to
a189afa
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR is part of the effort to address: IntersectMBO/cardano-api#1382. The PR addresses the 5th checkbox of the 6th step: "Accept standalone signed and unsigned sub-transaction envelopes for inspection.".
Basically, we just add support for sub-transactions to
transaction view. We do it both in--tx-fileor--tx-body-file, the difference, as with top-transactions, is just that the list of signatures is not showed by--tx-body-file. Just for backwards compatibility, I think it would make sense to unify this.How to trust this PR
Small change and follows the same behaviour as with top-transactions.
I would consider two things:
sub-transaction view?readFileTxOrSubTxsubsumereadFileTxBodyandreadFileTxfaithfully? I think it doesThe PR also includes a golden file for a signed sub-transaction and an unsigned sub-transaction.
Checklist
.changes/