Repository navigation
fix(tests): parse pending BLS keys correctly - #3816
Merged
Merged
Conversation
Read pending BLS keys directly when the query returns a plain key record, while retaining support for wrapped key-state records. Previously, looking for bksKey in a plain record returned an empty dict and caused both rotation tests to fail their pending-key check. Update the helper documentation to explain the two query formats. Validation: make lint passed; E2E tests were not rerun.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read pending BLS keys directly when the query returns a plain key record, while retaining support for wrapped key-state records. Previously, looking for bksKey in a plain record returned an empty dict and caused both rotation tests to fail their pending-key check.
Update the helper documentation to explain the two query formats. Validation: make lint passed; E2E tests were not rerun.