Skip to content

feat: add isolated POGM with gradient restart, optional early stopping, & reduced allocations - #163

Open
XiaochuanLyu wants to merge 1 commit into
JeffFessler:mainfrom
XiaochuanLyu:pogm-gradient-restart
Open

XiaochuanLyu wants to merge 1 commit into
JeffFessler:mainfrom
XiaochuanLyu:pogm-gradient-restart

Conversation

@XiaochuanLyu

Copy link
Copy Markdown

pogm_restart runs for a fixed iteration budget, and callback return values do not control stopping. This adds pogm_restart_gr, an isolated POGM + gradient restart implementation with opt-in convergence checks, while leaving the existing solver unchanged.

  • Preserve the original trajectory by default, including the special final momentum step and primary/secondary iterate callback behavior.
  • Add optional absolute/relative proximal-gradient mapping tolerances, check intervals, and convergence information. Checks evaluate the standard mapping at the returned secondary iterate; an early exit does not recompute a special final step.
  • Reduce temporary arrays with fused broadcasts and support optional f_grad! / g_prox! callbacks without changing existing callers. Iterate/history allocation remains; this is not an allocation-free solver.
  • Add numerical trajectory comparisons, stopping and callback-reference tests, and a standalone synthetic L1 logistic / squared-hinge benchmark.

Validation: the complete repository test/runtests.jl passed on Julia 1.13.3, including Aqua (11/11), existing POGM tests (3/3), and the new solver tests (756/756). The standalone benchmark passed its residual, objective-gap, and solution-error accuracy checks. The documentation site was not built.

@XiaochuanLyu
XiaochuanLyu marked this pull request as draft November 3, 2026 18:55
@XiaochuanLyu XiaochuanLyu changed the title Add isolated POGM with gradient restart and optional early stopping feat: add isolated POGM with gradient restart, optional early stopping, & reduced allocations Nov 3, 2026
@XiaochuanLyu
XiaochuanLyu marked this pull request as ready for review November 3, 2026 18:56

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant