Repository navigation
💾: expect contextual ObjectDB network errors - #1880
Merged
Merged
Conversation
Since #1855, lively.resources wraps failed requests in an error whose message names the method and URL ("Cannot GET <url>: <message>.") and keeps the original error as `cause`. The ObjectDB client test still expected the bare network message. Check the contextual message and the preserved cause for both _GET and _POST instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore the daily status check on main. Since #1855, lively.resources wraps failed requests in an error naming the method and URL (
Cannot GET <url>: <message>.) and keeps the original error ascause. The ObjectDB client test still expected the bare network message, solively.storage/tests/objectdb-resource-test.jshas failed every daily run since that merge. PR checks did not catch it because they only run tests for changed folders.The test now checks the contextual message and that the original error is preserved as
cause, for both_GETand_POST. No runtime code changes.Without this change the test fails with
expected 'Cannot GET http://objectdb.test/objec…' to equal 'network failure'; with it, all 8 tests in the file pass.