Repository navigation
Add GitHub CI and an STL regression corpus - #10
Merged
Merged
Conversation
….10-3.12, dev extras); five generated fixture parts with analytic volume/feature truth pinned by tests/test_corpus.py on the stable feature core plus a 1% corrected-volume gate (plan_to_mesh + canonical OVER/UNDER corrections)
The least-squares cone fit of the trimesh test cone is only good to ~1e-4, and the achieved precision varies with the numpy/LAPACK build (numpy 2.3+ drops Python 3.10, so that leg resolves a different numpy than 3.11/3.12). Assertions at atol=1e-6/1e-8 therefore passed on 3.11/3.12 but failed on 3.10 in CI. Loosen the four affected cone-fit assertions to 1e-3 (~4x margin over the worst observed deviation) while keeping the geometric intent of each test intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
pip install -e .[dev](no FreeCAD needed — the core is FreeCAD-free).fixtures/generate_corpus.py) with analytic volume and feature ground truth:tests/test_corpus.pypins the stable, correct core per part (feature kinds, diameters, depths, coverage floors), asserts mesh volumes match the analytic truth within 1%, and enforces the 1% corrected-volume gate viaplan_to_mesh+plan_corrections+apply_corrections.Notes
unplannedas an open slot). Pinned separately when closed.