Repository navigation
Add tapered-boss (convex cone) feature: detect, plan, rebuild as AdditiveCone - #12
Merged
Merged
Conversation
…n a face, capped-or-pointed tip), plan as an additive ConeOp, and rebuild as a PartDesign::AdditiveCone (base sunk into the face off the coincident boolean, tip exact). The core already fit convex cones but had no additive path, so a tapered boss was left unassigned and the terrace machinery substituted a straight-walled pad of the base radius. Also exclude the tip cap from the base extent (like the cylindrical boss cap) so the base pad is not inflated to the boss top, and fix the additive profile in the two headless rebuilds (_rebuild_mesh, plan_to_mesh). 23 new test_cone_boss.py tests (detection/planning/round-trip) + a smoke case; headless suite 525 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Phase 2, item 1 (feature depth). The core already fit convex cones (coverage 1.0), but the planner/executor had no additive path — so a tapered boss (conical stud, draft-angled boss) was left unassigned, and the terrace machinery substituted a straight-walled pad of the base radius: the right footprint at the wrong profile, reported as a clean reconstruction.
What
features.py): newcone_bossrule — a full-revolution convex cone whose wide end (base) opens at a face and whose narrow end (tip) is capped by a disk or runs to a point. The convex mirror image of the existingcone_pocketrule; claimed only when both ends are explained, else left unassigned (honesty contract).history.py):cone_boss→ additiveConeOp(r_mouth=base radius,r_far=tip,additive=True). The tip cap is excluded from the base extent (like the cylindrical boss cap), so the base pad is not inflated to the boss top.build.py): additive branch in the cone dispatch →PartDesign::AdditiveCone. The base leg is sunk a hair into the face (off the coincident-face boolean, the cut buffer doctrine applied to an add); the tip is placed exactly (it is the outermost point — extending it would overshoot the source)._rebuild_mesh(test) andplan_to_mesh(deviation-correction path) so a boss rebuilds as a boss.test_cone_boss.pytests (detection, negatives, planning, round-trip) + a tapered-boss smoke case. Headless suite 525 passed / 1 xfailed; smoke 97/97 in FreeCAD 1.1.4.Verification
.venv/bin/python -m pytest freecad/meshtofeatures_wb/tests/ -q→ 525 passed, 1 xfailed (was 502).PartDesign::AdditiveCone.plan_to_mesh+ corrections: <0.01% volume for both truncated and pointed bosses.Docs synced: README (feature + limitations), CHANGELOG, ROADMAP (Phase 2 item 1 marked done).