Repository navigation
Let capacity pressure expire idle unattached Environments - #936
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pinned Agents API has no Environment delete. Today, an idle suspended standalone Environment with no Session attached holds its node's retained slot until snapshot retention ends (24 h). With more prewarms than
max_retained, the node blocks new placement for that whole time.This change makes such an Environment eligible for capacity-pressure release. When a node's retained slots are full and waiting placement is blocked by them, pressure can release the node's oldest idle suspended allocation of an unattached standalone Environment. The Environment then expires exactly as at its deadline: status
expired, workspace and placement released.IsUnattachedRuntimeEnvironment: the Environment is active and no live Session is attached.AllocationTx.CanReleaseCheckpointisCanRetainEnvironmentor unattached. It is checked under the same Environment lock as before.ExpireCheckpointForDemand, by the full-node suspension gate and by the oldest-peer scan.CanRetainEnvironment.docs/sandbox-provider.md, the lifecycle without a Session inenvironments.md, and a ledger entry inindex.md.Verification
go vetpasses on the deployment and deploymentpg packages, andgo test ./internal/deployment/passes.check-translationspasses.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.