Skip to content

Add LDAP login provider, provider-linked account lifecycle, and a shared provider-customizable login form - #1155

Merged
tariqksoliman merged 123 commits into
developmentfrom
devin/1793737998-ldap-auth-provider
Nov 10, 2026
Merged

Add LDAP login provider, provider-linked account lifecycle, and a shared provider-customizable login form#1155
tariqksoliman merged 123 commits into
developmentfrom
devin/1793737998-ldap-auth-provider

Configure: dark account popover matching the main site's account menu

7c77fba
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Nov 5, 2026 in 15m 36s

Quality Gate passed

Issues
230 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.5% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 178 in plugins/core/backend/Access/routes/access.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not use nested template literals. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGl2y6Ka491iWGEzh-k&open=AaGl2y6Ka491iWGEzh-k&pullRequest=1155

Check warning on line 78 in plugins/core/backend/Access/routes/access.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGtVf0krRkUM4lF8IYt&open=AaGtVf0krRkUM4lF8IYt&pullRequest=1155

Check warning on line 1103 in API/permissions/providers.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected `await` inside a loop. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGoi1jIZSWqbIzFb51x&open=AaGoi1jIZSWqbIzFb51x&pullRequest=1155

Check warning on line 35 in configure/src/pages/UsersAccess/PeopleTab.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

The catch parameter `res` should be named `error_`. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGk9dbbyCqF7sywwNWM&open=AaGk9dbbyCqF7sywwNWM&pullRequest=1155

Check warning on line 80 in configure/src/pages/UsersAccess/PersonPanel.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

The catch parameter `res` should be named `error_`. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGkVY33DEw5iyEO_juH&open=AaGkVY33DEw5iyEO_juH&pullRequest=1155

Check warning on line 93 in plugins/core/auth/Ldap/plugin.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGkpFk-3TRbxogAO-6D&open=AaGkpFk-3TRbxogAO-6D&pullRequest=1155

Check warning on line 707 in configure/src/pages/UsersAccess/shared.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGtsas6A6bPCcVW8T8B&open=AaGtsas6A6bPCcVW8T8B&pullRequest=1155

Check warning on line 560 in plugins/core/backend/Accounts/routes/accounts.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not use nested template literals. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGoi2HPZSWqbIzFb52Z&open=AaGoi2HPZSWqbIzFb52Z&pullRequest=1155

Check warning on line 369 in API/permissions/providers.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGk9dEdyCqF7sywwNV9&open=AaGk9dEdyCqF7sywwNV9&pullRequest=1155

Check failure on line 24 in configure/src/pages/UsersAccess/PersonPanel.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGoi19UZSWqbIzFb514&open=AaGoi19UZSWqbIzFb514&pullRequest=1155

Check warning on line 484 in src/essence/Basics/UserInterface_/components/Login/Login.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGkpFSl3TRbxogAO-5y&open=AaGkpFSl3TRbxogAO-5y&pullRequest=1155

Check warning on line 171 in plugins/core/auth/Ldap/plugin.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGkpFk-3TRbxogAO-6E&open=AaGkpFk-3TRbxogAO-6E&pullRequest=1155

Check warning on line 84 in configure/src/pages/UsersAccess/PersonPanel.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGkpFaZ3TRbxogAO-54&open=AaGkpFaZ3TRbxogAO-54&pullRequest=1155

Check failure on line 574 in plugins/core/auth/Ldap/plugin.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 19 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGoi2OIZSWqbIzFb52f&open=AaGoi2OIZSWqbIzFb52f&pullRequest=1155

Check failure on line 319 in API/permissions/providers.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 26 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGoi1jIZSWqbIzFb51F&open=AaGoi1jIZSWqbIzFb51F&pullRequest=1155

Check warning on line 310 in plugins/core/auth/Ldap/plugin.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected `await` inside a loop. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGk9doYyCqF7sywwNWZ&open=AaGk9doYyCqF7sywwNWZ&pullRequest=1155

Check warning on line 361 in plugins/core/backend/Access/routes/access.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

arrow function is equivalent to `Boolean`. Use `Boolean` directly. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGk9dmEyCqF7sywwNWX&open=AaGk9dmEyCqF7sywwNWX&pullRequest=1155

Check warning on line 1107 in API/permissions/providers.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGoi1jIZSWqbIzFb51z&open=AaGoi1jIZSWqbIzFb51z&pullRequest=1155

Check warning on line 378 in API/permissions/providers.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the opposite operator (<=) instead. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGoi1jIZSWqbIzFb51L&open=AaGoi1jIZSWqbIzFb51L&pullRequest=1155

Check warning on line 183 in configure/src/components/AccountMenu/AccountMenu.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGtVfpYrRkUM4lF8IYh&open=AaGtVfpYrRkUM4lF8IYh&pullRequest=1155

Check warning on line 189 in configure/src/components/AccountMenu/AccountMenu.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not use nested template literals. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGtVfpYrRkUM4lF8IYl&open=AaGtVfpYrRkUM4lF8IYl&pullRequest=1155

Check warning on line 494 in API/permissions/providers.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGoi1jIZSWqbIzFb51N&open=AaGoi1jIZSWqbIzFb51N&pullRequest=1155

Check warning on line 517 in plugins/core/backend/Accounts/routes/accounts.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGoi2HPZSWqbIzFb52W&open=AaGoi2HPZSWqbIzFb52W&pullRequest=1155

Check warning on line 908 in API/permissions/providers.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseFloat` over `parseFloat`. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGkOPlG-Lu4Ca1Pzda9&open=AaGkOPlG-Lu4Ca1Pzda9&pullRequest=1155

Check warning on line 892 in API/permissions/providers.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMGIS&issues=AaGl2ySJa491iWGEzh-e&open=AaGl2ySJa491iWGEzh-e&pullRequest=1155
View more details on SonarQubeCloud