Repository navigation
feat: inspect generated shell helpers and archived sources - #974
Merged
Merged
Conversation
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
yashrajp22
force-pushed
the
yashraj/driveos-generated-code-inspection
branch
from
November 4, 2026 12:14
3203c12 to
cbccc9d
Compare
yashrajp22
added a commit
that referenced
this pull request
Nov 4, 2026
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Retain conservative marker accounting when unrelated string closers cannot prove the original token. Cover line endings, quote styles and later raw findings. Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspect supported shell programs reconstructed from uploaded sources, generated helpers and archives. Recovered findings retain the consuming command's location and source provenance. Unknown identity, source mutation, unsupported execution and resource limits remain explicitly incomplete.
The change tracks bounded source/artifact state and assignment-time values, audits helper effects before reusing bytes, and applies existing normalized and declared-marker security checks within the parent's deadline and finding budget. Child failures retain the first unresolved cause at the enclosing consumer without losing earlier findings.
Compatible correction:
40e8543260f3f1cb645d365c46267bb0515727f7. This branch incorporates #973, #997 and #999; those prerequisites should merge first. Independent retry and TAR/GZIP work remains in #998 and #1000.The latest correction carries #973's bounded constant-field proof and import-evidence guards through the typed/generated-source integration. Opaque imports and known omitted inventory paths cannot establish optional caller proof. The original shell-security assertion remains intact.
Current follow-up evidence:
1aa76e62passes 597 focused checks from source and 597 from its fresh wheel. Full unchanged CAD static inspection reaches 109/109 in both modes, with security findings and reference caveats retained.a8b67911passes 3,384/3,384 focused checks in each mode, across 13 modules. All 148 fresh-wheel package files match source. Its 50 offline scans have exact source/wheel parity in all 25 pairs and satisfy 46/46 controls. Only CAD changes from6d90c033: 108/109 becomes 109/109 without finding changes; all other normalized findings and inspection accounting match.Prior evidence remains bound to earlier heads:
8ad763cbpassed 2,256/2,256 installed-package checks; combined6d90c033completed 100 offline and 50 live scans with 44/44 static controls in each, exact offline source/wheel parity and 52/52 live typed-message checks. Its 3,283 focused parser and 97 batch-security checks passed. Seven live runs retained AI-review limitations. Earlier740d14a8evidence comprises 180 offline scans with 146 control expectations and 44 live scans with 38 targeted static expectations; its AI degradation remains recorded.DriveOS remains 9/10 in the new offline comparison. Its first gap is the quoted multiline
printfsubstitution attests/test_workflow.sh:409–410(unsupported_syntax/printf_invocation): safe reconstruction is unproved in its sourced/handler-capable shell context. That diagnostic does not establish invalid Bash or an outside-bundle dependency. CAD's earlier 108/109 result is historical; the standalone and combined follow-up both restore 109/109 offline.This PR remains draft: current-head CI has five successful jobs and its unit job is still running. Greptile reviewed the three-file #973 correction with no security finding and one nonblocking inventory-indexing suggestion, which was evaluated and deferred; that scope does not cover this entire stacked integration. CodeRabbit failed before analysis. Coverage, vulnerabilities and provider failures are separate conclusions; incomplete inspection alone does not prove a vulnerability.