Skip to content

[19.0][ADD] stock_readonly: readonly access for Inventory application - #2500

Merged
OCA-git-bot merged 1 commit into
OCA:19.0from
akretion:19.0-add-stock_readonly
Nov 3, 2026
Merged

[19.0][ADD] stock_readonly: readonly access for Inventory application#2500
OCA-git-bot merged 1 commit into
OCA:19.0from
akretion:19.0-add-stock_readonly

Conversation

@sebalix

@sebalix sebalix commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This was referenced Oct 23, 2026
Open
Open
@sebalix
sebalix force-pushed the 19.0-add-stock_readonly branch 2 times, most recently from 3a80cec to 47f3098 Compare October 23, 2026 06:46
@sebalix
sebalix marked this pull request as ready for review October 23, 2026 06:51
BhaveshHeliconia
BhaveshHeliconia reviewed Oct 23, 2026
View reviewed changes
Comment thread stock_readonly/views/stock_menus.xml Resolved
Comment thread stock_readonly/security/ir.model.access.csv Resolved
Comment thread stock_readonly/tests/test_stock_readonly.py Resolved
@sebalix

sebalix commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Thank you @BhaveshHeliconia , I pushed a fixup that should fix all your points. There is a test user created on the runbot if needed (and I added missing RO access rights on delivery.carrier, picking batch etc manually, that will be done in new modules later, I don't need them for now).

BhaveshHeliconia
BhaveshHeliconia approved these changes Oct 26, 2026
View reviewed changes

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

HekkiMelody
HekkiMelody approved these changes Oct 29, 2026
View reviewed changes

@HekkiMelody HekkiMelody left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

Comment thread stock_readonly/security/res_groups.xml Resolved
@OCA-git-bot

OCA-git-bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot

OCA-git-bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

SirPyTech
SirPyTech approved these changes Nov 2, 2026
View reviewed changes

@SirPyTech SirPyTech left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this module!
This could be very useful 😊
I reviewed the code and only had a couple of small suggestions to simplify the implementation, but this looks good already 👏
I also tried going through the Inventory app with a readonly user and everything works as expected.

Comment thread stock_readonly/views/stock_menus.xml Resolved
Comment thread stock_readonly/tests/test_stock_readonly.py Resolved
SirPyTech
SirPyTech suggested changes Nov 2, 2026
View reviewed changes

@SirPyTech SirPyTech left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only blocking to remind that the fixup commit must be removed Image

@sebalix

sebalix commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Thank you @SirPyTech, I addressed your comments. I'll squash the fixups once you're OK with the PR.

Do not hesitate to review the sibling ones that would help :)

@SirPyTech

SirPyTech commented Nov 3, 2026

Copy link
Copy Markdown

Thank you @SirPyTech, I addressed your comments. I'll squash the fixups once you're OK with the PR.

Do not hesitate to review the sibling ones that would help :)

Thanks, now the changes are good for me, you can squash all the commits 🙏

HekkiMelody
HekkiMelody approved these changes Nov 3, 2026
View reviewed changes

@HekkiMelody HekkiMelody left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@sebalix
[ADD] stock_readonly: readonly access for Inventory application
d1c2fe8 
Provides a read-only group for Inventory application.

Assisted-by: mistral/zai-glm-5-3
@sebalix
sebalix force-pushed the 19.0-add-stock_readonly branch from cd38f65 to d1c2fe8 Compare November 3, 2026 10:02
@sebalix

sebalix commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

@SirPyTech squashed!

@sebalix

sebalix commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 19.0-ocabot-merge-pr-2500-by-sebalix-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 6b67967 into OCA:19.0 Nov 3, 2026
7 of 8 checks passed
@OCA-git-bot

OCA-git-bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 3b27dda. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@HekkiMelody HekkiMelody HekkiMelody approved these changes
@BhaveshHeliconia BhaveshHeliconia BhaveshHeliconia approved these changes
@SirPyTech SirPyTech SirPyTech approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 mod:stock_readonly Module stock_readonly series:19.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sebalix @OCA-git-bot @SirPyTech @HekkiMelody @BhaveshHeliconia