Repository navigation
refactor(nextflow): lower from a resolved view of the graph #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2a35d6a
design: Nextflow lowers from a resolved view
vjaganat90 ce84178
refactor: the safe subset moves to lang.subset
vjaganat90 5cbd7be
test(nextflow): cases compile through compile_source
vjaganat90 cadb0cd
refactor(ir): the resolved view of the graph
vjaganat90 852cfc2
refactor(nextflow): lower from the resolved view
vjaganat90 0b58b86
refactor(nextflow): refusals at the user's line
vjaganat90 6053479
refactor(nextflow): delete the CWL projection
vjaganat90 6bce14c
ci: lanes select by marker, and the CWL corpus has one
vjaganat90 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before this change, this job ran
-m "not skip_pypi_ci and not nextflow", nearly the whole suite. It was the only PR lane for about 94 test functions, which now run only in the weekly lanes. Most of them are fast core tests:test_lang_parser.py(32),test_lang_schema.py(11),test_names_emitted.py(10),test_lang_render.py(9),test_canonical_path.pyandtest_reference_compatibility.py(6 each), andtest_leak_boundary.py(5). The corpus parse and round-trip checks over the in-repo tutorials (test_corpus_files_parse,test_corpus_round_trips,test_accepts_the_whole_corpus) are now markedcwl_corpus, but neither Run Workflows nor Lint And Test collects them. Only Property Weekly runs them. So the newcwl_corpusmarker text inpyproject.tomland the header ofpython_matrix_weekly.ymloverstate where they run.After this change, a parser, schema or emitted-name regression passes PR CI and shows up only in the weekly run. Could these fast files keep a PR lane, either by marking them
packageor by giving them a Lint And Test step?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right that these no longer gate PRs. Putting all 94 back as they are isn't the fix, though. About 35 of them are already properties, and most of the rest are examples written before the property in the same file covered them, or checks on how a module is built rather than what it does.
test_parse_casealone runs 137 inline snippets. A follow-up on top of this stack folds them into about 25 tests, one property per rule plus a few readable.wicexamples in files for the diagnostics and the emitted names, and those gate PRs again. Until it lands they run in the weekly lanes.On
cwl_corpus:CORPUS(tests/core/wic_corpus.py) is whateversearch_paths_wicreaches. That is the same discoverytest_run_workflows_on_pushruns, and in CI it covers mm-workflows, image-workflows anddocs/tutorials. The in-repo fallback is only what Property Weekly sees, because it has no config. So the marker is right. You're also right that no PR lane collects these three: Run Workflows picks its tests by name. The follow-up makes them one corpus test.