Repository navigation
ci: auto-approve skill sync pull requests - #263
Merged
Merged
Conversation
GeneralistDev
approved these changes
Oct 16, 2026
GeneralistDev
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Skill sync PRs already enable auto-merge but still wait for the approval required on
main, duplicating review of the upstream changes.Changes
I use the GitHub Actions identity to approve PRs created by the release app. The app still creates the PR and enables auto-merge, so approval uses a separate identity.
Before rollout, an admin must enable Actions approvals and make
testsa required check onmain. These settings are outside this diff; my attempt to enable Actions approvals returned HTTP 403. I documented setup and live verification in.github/README.md.How did you test this code?
ghstub, checking token identities and failure handling. Removing the separate approval identity made the check fail before merge.The approval and merge flow still needs live verification after the admin settings and workflow change land.