Repository navigation
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused consolidation retains conversion and argument constraints, with no unresolved blocking findings.
No open issues 🎉
What changed in this PR
Consolidates abstract-game forwarding methods into GameTheory.jl’s implementations, reducing duplication while preserving intended behavior.
Changes:
- Merge forwarding methods and retain conversion to
NormalFormGame. - Update argument documentation for abstract games.
- Document the repeated-game constructor and correct discount-factor terminology.
Assisted-by: GitHub Copilot (model unspecified)
| File | Description |
|---|---|
| src/vertex_enumeration.jl | Consolidate enumeration and task entry points. |
| src/repeated_game.jl | Consolidate and document game construction. |
| src/pure_nash.jl | Merge forwarding and use the player-count type parameter. |
| src/lrsnash.jl | Convert abstract games within the implementation. |
| src/localint.jl | Consolidate the game-based constructor. |
| src/lemke_howson.jl | Merge the non-mutating solver entry point. |
| src/homotopy_continuation.jl | Consolidate solver dispatch for abstract games. |
| src/fictplay.jl | Consolidate both fictitious-play constructors. |
Review effort: Balanced
Member
Author
|
For the nightly failure, wait for JuliaLinearAlgebra/GenericLinearAlgebra.jl#185 to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
pure_nash,lemke_howson,vertex_enumeration(andvertex_enumeration_task),lrsnash,hc_solve,FictitiousPlay,StochasticFictitiousPlay,LocalInteraction, andRepeatedGame, the method onAbstractNormalFormGamethat forwarded to theNormalFormGamemethod throughconvertis merged into that method, which now takes anAbstractNormalFormGameand converts it on entry: the identity on aNormalFormGame, one tabulation otherwise. One commit per function.This removes the duplicated signatures and keyword defaults, and the trap of a forwarding method that matches a
NormalFormGamewith an invalid second argument and recurses throughconvert. The docstrings now document theAbstractNormalFormGameargument;RepeatedGame(g, delta)gets a docstring, and "discount rate" is corrected to "discount factor".Behavior-preserving.
support_enumerationkeeps its forwarding methods, since its 2-player and N-player methods differ, andlemke_howson!still takes aNormalFormGame.🤖 Generated with Claude Code (Claude Fable 5.1)