Repository navigation
capture the calling scope once as callenv in [ - #7934
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## bracket_modularization #7934 +/- ##
=========================================================
Coverage ? 99.09%
=========================================================
Files ? 88
Lines ? 17440
Branches ? 0
=========================================================
Hits ? 17282
Misses ? 158
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ben-schwen
force-pushed
the
brk/a3_callenv
branch
from
October 24, 2026 10:13
bc5c7da to
010b00c
Compare
ben-schwen
force-pushed
the
brk/a3_callenv
branch
from
October 24, 2026 23:13
010b00c to
07544cf
Compare
(Plot image upload to picrd.com failed; download the artifact below to view plots) Generated via commit 8ba52a7 Download link for the artifact containing the test results: ↓ atime-results.zip
|
| setalloccol(x, n, verbose=verbose) # always assigns to calling scope; i.e. this scope | ||
| if (is.name(name)) { | ||
| assign(as.character(name),x,parent.frame(),inherits=TRUE) | ||
| assign(as.character(name),x,callenv,inherits=TRUE) |
Member
There was a problem hiding this comment.
while we're here
Suggested change
| assign(as.character(name),x,callenv,inherits=TRUE) | |
| assign(as.character(name), x, callenv, inherits=TRUE) |
| assign(as.character(name),x,callenv,inherits=TRUE) | ||
| } else if (.is_simple_extraction(name)) { | ||
| .reassign_extracted_table(name, x) | ||
| .reassign_extracted_table(name, x, callenv) |
Member
There was a problem hiding this comment.
nice! this one's tougher to spot
Line 129 in e24d1b8
MichaelChirico
approved these changes
Oct 26, 2026
ben-schwen
force-pushed
the
brk/a3_callenv
branch
2 times, most recently
from
November 1, 2026 21:02
74c52e9 to
c050ddb
Compare
ben-schwen
force-pushed
the
brk/a3_callenv
branch
from
November 1, 2026 22:20
c050ddb to
389acda
Compare
Base automatically changed from
brk/a2_missing_flags
to
bracket_modularization
November 3, 2026 09:18
ben-schwen
force-pushed
the
brk/a3_callenv
branch
2 times, most recently
from
November 3, 2026 10:27
17a48e2 to
734378d
Compare
Capture parent.frame() once at the top as callenv and use that for every evaluation in the caller's scope (i, j, by, .SDcols, on, :=, ..var, the .N swap, SDenv's parent, ...). No behaviour change.
ben-schwen
force-pushed
the
brk/a3_callenv
branch
from
November 3, 2026 10:30
734378d to
8ba52a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #852
Caches calling scope via
parent.frame()